1572932 - nested-context-navigations-iframe.html passes by accident

Status: RESOLVED FIXED

(Core :: DOM: Performance, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

nested-context-navigations-iframe.html's history.back() tests work only because they use https://searchfox.org/mozilla-central/source/testing/web-platform/tests/resource-timing/resources/navigate_back.html which does back() within a load event listener, which means in Gecko the current session history entry is replaced by a new load.

Bug 1563587 makes history.back() asynchronous, and the test starts to fail.
But the test fails already now if one uses setTimout
window.onload = function() { setTimeout("history.back();")}

The test passes with or without the timeout in other browsers which already have
asynchronous history.back()

Comment 1

[Natalia Csoregi [:nataliaCs]]

:Olli this started permafailing once Bug 1563587 has landed:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=windows%2C10%2Caarch64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows10-aarch64%2Fopt-web-platform-tests-e10s-11%2Cw%28wpt11%29&revision=a6ba020c9f7cd1abecd8eb2287020468ec1da6e8
Is there any chance you could take a look?
Thank you.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

aha, only on some platform

Comment 3

[Intermittent Failures Robot]

28 failures in 4839 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 27
• autoland: 1

Platform breakdown:

• windows10-aarch64: 28

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1572932&startday=2019-08-12&endday=2019-08-18&tree=all

Comment 5

[Alexandru Michis [:malexandru]]

Olli, any updates on this? It's still perma-failing:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=windows%2C10%2Caarch64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows10-aarch64%2Fopt-web-platform-tests-e10s-11%2Cw%28wpt11%29&tochange=0dc91d87721bbd95ec2bccd1bfff87f22125ae6d&fromchange=ce8742e6c77b7aef8a2beba32776ca3494adacb8

Should we update the expectations on "nested-context-navigations-iframe.html" for the time being?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Yes, that is what I'm planning to do, just update the expectations. The actual bug has been there before Bug 1563587.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

I have no plans to fix this particular bug atm, just let the test pass or fail. So the .ini change shouldn't happen in this bug.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

So far I haven't figured out how to mark a test intermittently passing/failing.
expected: [PASS, FAIL] in .ini doesn't work.
I guess I just disable

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[PASS, FAIL] is for steps: https://searchfox.org/mozilla-central/rev/597a69c70a5cce6f42f159eb54ad1ef6745f5432/testing/web-platform/meta/pointerevents/pointerlock/pointerevent_movementxy_with_pointerlock.html.ini#3
For the whole test, use [OK, FAIL], similar to https://searchfox.org/mozilla-central/source/testing/web-platform/meta/cookie-store/serviceworker_cookieStore_subscriptions.tentative.https.html.ini#3

Comment 10

[Intermittent Failures Robot]

15 failures in 5073 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 14
• try: 1

Platform breakdown:

• windows10-aarch64: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1572932&startday=2019-08-19&endday=2019-08-25&tree=all

Comment 11

[Neha Kochar [:neha]]

Not related to Fission.
See comment 8.

Comment 12

[Sean Feng [:sefeng]]

If I read the description correctly, the test should pass with asynchronous history.back()? I am not sure what the original state of the test is, but looks like it's passing now https://wpt.fyi/results/resource-timing/nested-context-navigations-iframe.html?label=master&product=chrome%5Bexperimental%5D&product=edge&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&aligned ?

Do you think this bug is still relevant Olli?

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 20 votes.
:fdoty, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

The test has been changed after this bug was filed. Pushing to try without the .ini file to see whether this passes everywhere.
At least the test passes locally on linux.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1572932 - enable subtests in nested-context-navigations-iframe.html, r=peterv

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b3ec632a18a
enable subtests in nested-context-navigations-iframe.html, r=peterv

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5b3ec632a18a