1572952 - regression: Kurento Loopback with recording using generators not working

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect, P3)

Description

[Asif Youssuff]

As reported initially on https://www.reddit.com/r/firefox/comments/co98ef/kurento_fails_on_ubuntu_1804_firefox_68/

STR:

1. Navigate to: https://houselannister.vyou.ch/
2. Click "Start"
3. Give permissions to site for camera

What happens:

Console output on page says:

Error: Error adding candidate
Error: Error adding candidate
TypeError: arguments.unshift is not a function

Video does not appear on remote stream.

Expected result:

Video appears on remote stream, no errors in console.

17:58.27 INFO: No more inbound revisions, bisection finished.
17:58.27 INFO: Last good revision: 2ae5ad0cc2e26e35d3a3c0827f8ac54b8d16be83
17:58.27 INFO: First bad revision: 4cfdc4abb3f01714861097b093c6b65d27ef6074
17:58.27 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2ae5ad0cc2e26e35d3a3c0827f8ac54b8d16be83&tochange=4cfdc4abb3f01714861097b093c6b65d27ef6074

Comment 1

[Asif Youssuff]

Byron, can you look into this? Your commit caused this regression. Thanks!

Comment 2

[Asif Youssuff]

[Tracking Requested - why for this release]:

Regression in WebRTC affecting public sites.

Comment 3

[Byron Campen [:bwc]]

It just looks like whatever remote endpoint Kurento is using doesn't support the latest ICE candidate signaling from the spec.

Comment 4

[Asif Youssuff]

Isn't this a webcompat issue? Shouldn't it at least be filed as needs contact or something?

Comment 5

[Mike Taylor [:miketaylr]]

(In reply to Byron Campen [:bwc] from comment #3)

It just looks like whatever remote endpoint Kurento is using doesn't support the latest ICE candidate signaling from the spec.

Are we not concerned about this working in Chrome and no longer in Firefox? Or will Chrome break this soon, do you know Byron?

Comment 6

[Byron Campen [:bwc]]

(In reply to Mike Taylor [:miketaylr] from comment #5)

(In reply to Byron Campen [:bwc] from comment #3)

It just looks like whatever remote endpoint Kurento is using doesn't support the latest ICE candidate signaling from the spec.

Are we not concerned about this working in Chrome and no longer in Firefox? Or will Chrome break this soon, do you know Byron?

Kurento should not be treating this as a fatal error anyway. We're signaling additional information in a manner it doesn't support yet, that it could be ignoring. Kurento needs to update their code. I suppose if this continues to be a problem, we can disable these new onicecandidate events until the implementation community catches up.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Too late for 69 at this point with RC coming next week.

Comment 8

[Mike Taylor [:miketaylr]]

(Not sure if we should track this if it relies on the site to update code.)

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Untracking since this is an external issue.

Comment 10

[Karl Dubost💡 :karlcow]

This is "working" the same way in Safari, Firefox and Chrome.

For example in Chrome.
WebSocket connection to 'wss://houselannister.vyou.ch:8433/kurento' failed: Error in connection establishment: net::ERR_SSL_OBSOLETE_VERSION