1573063 - should blue dot indicating no tracking protection be on the app menu toolbar button?

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Cameron McCormack (:heycam)]

Attachment: screen shot

When I'm viewing a page that I've turned tracking protection off for, I see a blue dot on the app menu toolbar icon. Is that its intended location? When I mouse over it, the shield button to the left of the address gets a hover highlight, so I'm wondering if it should be over there.

Comment 1

[Cameron McCormack (:heycam)]

Hi Tim, can you say what the intended location of the blue dot is?

Comment 2

[Cameron McCormack (:heycam)]

needinfod the wrong Tim. :) (Although maybe both Tims know the answer!)

Comment 3

[Tim Huang[:timhuang]]

Hi Cameron,

This is not the intended location. The blue dot should be on the shield icon.

Comment 4

[Tim Huang[:timhuang]]

I will look into that to figure out what happens there.

Comment 5

[Tim Huang[:timhuang]]

This bug is regressed by Bug 1569872 cuz it accidentally removed the 'position: relative;' from the tracking protection icon container. This rule is needed in order to correctly position the blue dot.

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1573063 - Fix the position issue of the blue dot indicator of the tracking protection icon. r?johannh!

The patch adds back the 'position: relative;' rule to the tracking
protection icon container. This is need in order to position the blue
dot.

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Lol, this bug is really amusing, thanks for catching this!

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Tim Huang[:timhuang] from comment #5)

This bug is regressed by Bug 1569872 cuz it accidentally removed the 'position: relative;' from the tracking protection icon container. This rule is needed in order to correctly position the blue dot.

This wasn't accidental. I purposely removed position: relative because the border no longer needed it. But I forgot about the blue dot :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbf1928cb18a
Fix the position issue of the blue dot indicator of the tracking protection icon. r=nhnt11

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dbf1928cb18a

Comment 11

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 70.0a1 (2019.08.11) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 70.0b14 on Win 10 x64, macOS 10.13 and Ubuntu 18.04 x64.