Closed Bug 1573143 Opened 4 years ago Closed 4 years ago

Link certificate issuer to its respective certificate tab

Categories

(Firefox :: Security, enhancement, P1)

Product:
Firefox
Component:
Security
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- verified
firefox73 --- verified

People

(Reporter: danielleleb12, Assigned: danielleleb12)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Got
2.50 MB, image/png
Details
Expected
624.24 KB, image/png
Details
Bug 1573143 - Links certificate issuer to its respective tab. r=johannh
47 bytes, text/x-phabricator-request
Details | Review
Bug 1573143 - Adds test for linking issuer name to certificate tab. r=johannh
47 bytes, text/x-phabricator-request
Details | Review
linked-cert.mov
6.38 MB, video/quicktime
Details
No description provided.
Blocks: cert-viewer
Attached image Got —
Attached image Expected —
Status: NEW → ASSIGNED
Type: task → enhancement
Priority: -- → P1

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:danielleleb12, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(danielleleb12)

I rebased this on central and did a try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b3a789358883261807b5df3f43438b7fe20ee1e

There are still some failures, but I think these should be reproducible locally. Danielle, do you think you'll have time to take a look at this? :)

Yes taking a look now!

Flags: needinfo?(danielleleb12)

I'll try to get this landed... :)

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43410a278604
Links certificate issuer to its respective tab. r=johannh
https://hg.mozilla.org/integration/autoland/rev/8ca11a6e2a3a
Adds test for linking issuer name to certificate tab. r=johannh

Backed out 2 changesets (Bug 1573143) for browser_certViewer.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s&tochange=5a1fbc74dc673d5507d4894640d74d3fe32d68ac&fromchange=7a3383771d07ce1fb35768864ed02561cf4e841d&selectedJob=268758989

Backout link: https://hg.mozilla.org/integration/autoland/rev/21b0cdb2c7c5b5ae5961abe65e88ff72b300df42

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268758989&repo=autoland&lineNumber=14551

[task 2019-09-27T11:33:33.865Z] 11:33:33 INFO - TEST-START | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js
[task 2019-09-27T11:33:33.919Z] 11:33:33 INFO - GECKO(2060) | [2068, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:33.919Z] 11:33:33 INFO - GECKO(2060) | [2068, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:33.920Z] 11:33:33 INFO - GECKO(2060) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/pz/cx_1w9nx1dq_7zbylk7gbz30000017/T/tmpzVt37y.mozrunner/runtests_leaks_tab_pid2068.log
[task 2019-09-27T11:33:33.920Z] 11:33:33 INFO - GECKO(2060) | [2068, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:33.920Z] 11:33:33 INFO - GECKO(2060) | [2068, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:34.414Z] 11:33:34 INFO - GECKO(2060) | ++DOCSHELL 0x117f0a000 == 1 [pid = 2067] [id = {d29633d7-4bc4-4a4e-b2d2-facf876b7749}]
[task 2019-09-27T11:33:34.416Z] 11:33:34 INFO - GECKO(2060) | ++DOMWINDOW == 1 (0x10ffe4200) [pid = 2067] [serial = 1] [outer = 0x0]
[task 2019-09-27T11:33:34.419Z] 11:33:34 INFO - GECKO(2060) | ++DOMWINDOW == 2 (0x117de0400) [pid = 2067] [serial = 2] [outer = 0x10ffe4200]
[task 2019-09-27T11:33:34.783Z] 11:33:34 INFO - GECKO(2060) | --DOCSHELL 0x10b1e2800 == 1 [pid = 2062] [id = {a67d9913-3216-d34c-8420-8ec215ad4afd}] [url = about:blank]
[task 2019-09-27T11:33:35.009Z] 11:33:35 INFO - GECKO(2060) | ++DOCSHELL 0x11e30a800 == 1 [pid = 2068] [id = {628e535e-5b14-5948-8347-57cd118ff0e4}]
[task 2019-09-27T11:33:35.009Z] 11:33:35 INFO - GECKO(2060) | ++DOMWINDOW == 1 (0x11e341020) [pid = 2068] [serial = 1] [outer = 0x0]
[task 2019-09-27T11:33:35.009Z] 11:33:35 INFO - GECKO(2060) | ++DOMWINDOW == 2 (0x1187d5400) [pid = 2068] [serial = 2] [outer = 0x11e341020]
[task 2019-09-27T11:33:35.085Z] 11:33:35 INFO - GECKO(2060) | ++DOMWINDOW == 3 (0x11e3c2400) [pid = 2068] [serial = 3] [outer = 0x11e341020]
[task 2019-09-27T11:33:35.841Z] 11:33:35 INFO - GECKO(2060) | [2069, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:35.841Z] 11:33:35 INFO - GECKO(2060) | [2069, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:35.841Z] 11:33:35 INFO - GECKO(2060) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/pz/cx_1w9nx1dq_7zbylk7gbz30000017/T/tmpzVt37y.mozrunner/runtests_leaks_tab_pid2069.log
[task 2019-09-27T11:33:35.841Z] 11:33:35 INFO - GECKO(2060) | [2069, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:35.841Z] 11:33:35 INFO - GECKO(2060) | [2069, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2019-09-27T11:33:35.943Z] 11:33:35 INFO - TEST-INFO | started process screencapture
[task 2019-09-27T11:33:36.114Z] 11:33:36 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-27T11:33:36.114Z] 11:33:36 INFO - Buffered messages logged at 11:33:33
[task 2019-09-27T11:33:36.115Z] 11:33:36 INFO - Entering test bound testCAandTitle
[task 2019-09-27T11:33:36.115Z] 11:33:36 INFO - Buffered messages finished
[task 2019-09-27T11:33:36.115Z] 11:33:36 INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js | Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
[task 2019-09-27T11:33:36.115Z] 11:33:36 INFO - Leaving test bound testCAandTitle
[task 2019-09-27T11:33:36.115Z] 11:33:36 INFO - Entering test bound testSSLEndEntity
[task 2019-09-27T11:33:36.117Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x11a916000 == 3 [pid = 2061] [id = {1b495d4e-9f56-8a45-bfa6-2f1959ff24fd}] [url = moz-extension://f852540f-6058-234a-8281-47e101109998/_generated_background_page.html]
[task 2019-09-27T11:33:36.484Z] 11:33:36 INFO - GECKO(2060) | ++DOCSHELL 0x11ca0a800 == 1 [pid = 2069] [id = {9bdc3006-d806-134f-a167-4314dca01cb9}]
[task 2019-09-27T11:33:36.484Z] 11:33:36 INFO - GECKO(2060) | ++DOMWINDOW == 1 (0x11ca42020) [pid = 2069] [serial = 1] [outer = 0x0]
[task 2019-09-27T11:33:36.484Z] 11:33:36 INFO - GECKO(2060) | ++DOMWINDOW == 2 (0x116ed5400) [pid = 2069] [serial = 2] [outer = 0x11ca42020]
[task 2019-09-27T11:33:36.522Z] 11:33:36 INFO - GECKO(2060) | ++DOMWINDOW == 3 (0x11cabe800) [pid = 2069] [serial = 3] [outer = 0x11ca42020]
[task 2019-09-27T11:33:36.872Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x134ac6800 == 14 [pid = 2060] [id = {3a600865-9e9b-1742-a70c-eba258ce69a1}] [url = about:blank]
[task 2019-09-27T11:33:36.925Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x121c48800 == 13 [pid = 2060] [id = {6a270828-42d2-7d42-9614-0a71b6f719a0}] [url = about:blank]
[task 2019-09-27T11:33:36.967Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x136a61800 == 12 [pid = 2060] [id = {05fa8dea-86c3-3e44-ac07-e389e6e0117a}] [url = about:blank]
[task 2019-09-27T11:33:36.967Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x1330c3800 == 11 [pid = 2060] [id = {3fb7b57a-c9d0-d94c-81b8-e317f1689942}] [url = about:blank]
[task 2019-09-27T11:33:36.967Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x133462800 == 10 [pid = 2060] [id = {932b9ccb-c6a2-f547-ae33-8058ee29ad37}] [url = about:blank]
[task 2019-09-27T11:33:36.967Z] 11:33:36 INFO - GECKO(2060) | --DOCSHELL 0x12c69c800 == 9 [pid = 2060] [id = {3a0165c3-4811-f84a-a77a-667cda1ecf53}] [url = about:blank]
[task 2019-09-27T11:33:37.671Z] 11:33:37 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-27T11:33:37.673Z] 11:33:37 INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js | Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
[task 2019-09-27T11:33:37.673Z] 11:33:37 INFO - Leaving test bound testSSLEndEntity
[task 2019-09-27T11:33:37.673Z] 11:33:37 INFO - Entering test bound testEmailEndEntity
[task 2019-09-27T11:33:37.673Z] 11:33:37 INFO - GECKO(2060) | ++DOCSHELL 0x1109e7000 == 2 [pid = 2063] [id = {43e07d64-493b-084b-a005-2a8f3fd71c7e}]
[task 2019-09-27T11:33:37.673Z] 11:33:37 INFO - GECKO(2060) | ++DOMWINDOW == 4 (0x110b41200) [pid = 2063] [serial = 4] [outer = 0x0]
[task 2019-09-27T11:33:37.673Z] 11:33:37 INFO - GECKO(2060) | ++DOMWINDOW == 5 (0x110b0ec00) [pid = 2063] [serial = 5] [outer = 0x110b41200]
[task 2019-09-27T11:33:37.709Z] 11:33:37 INFO - GECKO(2060) | ++DOMWINDOW == 6 (0x14440ec00) [pid = 2063] [serial = 6] [outer = 0x110b41200]
[task 2019-09-27T11:33:38.343Z] 11:33:38 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-27T11:33:38.343Z] 11:33:38 INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js | Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
[task 2019-09-27T11:33:38.343Z] 11:33:38 INFO - Leaving test bound testEmailEndEntity
[task 2019-09-27T11:33:38.343Z] 11:33:38 INFO - Entering test bound testCodeSignEndEntity
[task 2019-09-27T11:33:38.361Z] 11:33:38 INFO - GECKO(2060) | ++DOCSHELL 0x125510800 == 2 [pid = 2064] [id = {a74ed240-60da-824f-ad41-a2de995d8cc8}]
[task 2019-09-27T11:33:38.362Z] 11:33:38 INFO - GECKO(2060) | ++DOMWINDOW == 4 (0x11f9a7d40) [pid = 2064] [serial = 4] [outer = 0x0]
[task 2019-09-27T11:33:38.362Z] 11:33:38 INFO - GECKO(2060) | ++DOMWINDOW == 5 (0x11eaed000) [pid = 2064] [serial = 5] [outer = 0x11f9a7d40]
[task 2019-09-27T11:33:38.385Z] 11:33:38 INFO - GECKO(2060) | ++DOMWINDOW == 6 (0x126e9c400) [pid = 2064] [serial = 6] [outer = 0x11f9a7d40]
[task 2019-09-27T11:33:39.190Z] 11:33:39 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-27T11:33:39.190Z] 11:33:39 INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js | Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
[task 2019-09-27T11:33:39.190Z] 11:33:39 INFO - Leaving test bound testCodeSignEndEntity
[task 2019-09-27T11:33:39.190Z] 11:33:39 INFO - Entering test bound testExpired
[task 2019-09-27T11:33:39.222Z] 11:33:39 INFO - GECKO(2060) | ++DOCSHELL 0x1183e9800 == 2 [pid = 2065] [id = {39af635c-0330-8c41-8fed-538a11fcf2bb}]
[task 2019-09-27T11:33:39.222Z] 11:33:39 INFO - GECKO(2060) | ++DOMWINDOW == 4 (0x11df3c200) [pid = 2065] [serial = 4] [outer = 0x0]
[task 2019-09-27T11:33:39.222Z] 11:33:39 INFO - GECKO(2060) | ++DOMWINDOW == 5 (0x1183d0c00) [pid = 2065] [serial = 5] [outer = 0x11df3c200]
[task 2019-09-27T11:33:39.267Z] 11:33:39 INFO - GECKO(2060) | ++DOMWINDOW == 6 (0x11e578c00) [pid = 2065] [serial = 6] [outer = 0x11df3c200]
[task 2019-09-27T11:33:39.723Z] 11:33:39 INFO - GECKO(2060) | --DOMWINDOW == 6 (0x10b39d800) [pid = 2062] [serial = 5] [outer = 0x0] [url = about:blank]
[task 2019-09-27T11:33:39.723Z] 11:33:39 INFO - GECKO(2060) | --DOMWINDOW == 5 (0x10b1d3800) [pid = 2062] [serial = 2] [outer = 0x0] [url = about:blank]
[task 2019-09-27T11:33:39.725Z] 11:33:39 INFO - GECKO(2060) | --DOMWINDOW == 4 (0x10b33a020) [pid = 2062] [serial = 1] [outer = 0x0] [url = about:blank]
[task 2019-09-27T11:33:39.923Z] 11:33:39 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-27T11:33:39.923Z] 11:33:39 INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_certViewer.js | Uncaught exception - TypeError: certificateSection.shadowRoot.querySelector(...) is null
[task 2019-09-27T11:33:39.923Z] 11:33:39 INFO - Leaving test bound testExpired
[task 2019-09-27T11:33:39.929Z] 11:33:39 INFO - Entering test bound testUnknownIssuer
[task 2019-09-27T11:33:39.931Z] 11:33:39 INFO - GECKO(2060) | ++DOCSHELL 0x12b24b000 == 10 [pid = 2060] [id = {8118a76f-d8d8-da4c-bd20-f625bf962206}]
[task 2019-09-27T11:33:39.931Z] 11:33:39 INFO - GECKO(2060) | ++DOMWINDOW == 32 (0x10c4255c0) [pid = 2060] [serial = 32] [outer = 0x0]
[task 2019-09-27T11:33:39.931Z] 11:33:39 INFO - GECKO(2060) | ++DOMWINDOW == 33 (0x10eba0c00) [pid = 2060] [serial = 33] [outer = 0x10c4255c0]
[task 2019-09-27T11:33:39.971Z] 11:33:39 INFO - GECKO(2060) | [Parent 2060, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 416
[task 2019-09-27T11:33:40.023Z] 11:33:40 INFO - GECKO(2060) | [Parent 2060, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp, line 3168
[task 2019-09-27T11:33:40.068Z] 11:33:40 INFO - GECKO(2060) | --DOCSHELL 0x1109dd800 == 1 [pid = 2063] [id = {42989383-0110-694a-80db-dea70063853b}] [url = about:blank]
[task 2019-09-27T11:33:40.325Z] 11:33:40 INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2019-09-27T11:33:40.325Z] 11:33:40 INFO - Version: 2.1 INTEL-12.9.22
[task 2019-09-27T11:33:40.325Z] 11:33:40 INFO - Vendor: Intel Inc.
[task 2019-09-27T11:33:40.325Z] 11:33:40 INFO - Renderer: Intel Iris OpenGL Engine
[task 2019-09-27T11:33:40.325Z] 11:33:40 INFO - FBO Texture Target: TEXTURE_2D
...

Flags: needinfo?(danielleleb12)

I missed a test when landing this...

Flags: needinfo?(danielleleb12)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4023aee4952c
Links certificate issuer to its respective tab. r=johannh
https://hg.mozilla.org/integration/autoland/rev/8ef34599da02
Adds test for linking issuer name to certificate tab. r=johannh

https://hg.mozilla.org/mozilla-central/rev/4023aee4952c
https://hg.mozilla.org/mozilla-central/rev/8ef34599da02

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Hello @danielleleb can you please provide some steps, or maybe a test page where we can reproduce this issue and confirm the fix ?

Flags: needinfo?(danielleleb12)

Sorry - what issue are you referring to?

Flags: needinfo?(danielleleb12)

I'm trying to confirm this enhancement as fixed but I'm not sure how to do that without steps and expected results. Is there anything you can help us with ? or can you confirm the fix in our latest Firefox Release so we can update the flags to Verified ?

Flags: needinfo?(danielleleb12)
Attached video linked-cert.mov —

This attachment (linked-cert.mov) shows that the bug is fixed.

Steps to reproduce fix:

  • Open Firefox and navigate to any site
  • Beside URL, click the lock
  • Click the right arrow, then click 'More Information'
  • Click 'View Certificate'
  • Click the link in 'Common Name' and it will navigate to the appropriate tab in the certificate viewer.
Flags: needinfo?(danielleleb12)

Yep, thanks a lot , This issue is Verified as fixed in our latest Release Version 73.0 on windows 10, Mac OSX 10.13 and Ubuntu 18.04

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
status-firefox73: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.