1573170 - [FxA]"Send Tab to Device" and "Synced Tabs" buttons are having different messages when you click on them - user is not logged in to sync

Status: RESOLVED WONTFIX

(Firefox :: Firefox Accounts, defect)

Description

[ovidiu boca[:Ovidiu]]

This issue was logged to add some consistency to this feature.

Affected versions

• Tested on FF Nightly 70.0a1(2019-08-11)

Affected platforms

• Tested on Mac Os X 10.14, Windows 10, Ubuntu 18.04

Steps to reproduce

Prerequisites: Don't login into FxA account.

Steps:

1. Click on the FxA toolbar icon
2. Click on "Send Tab to Device" - look at the button label
3. Click on "Synced Tabs" - look at the button label

Expected result

• I think in both cases the button label should be the same.

Actual result

• I have different messages, for the first action is "Sign in to Firefox" and for the second one is "Sign in to Sync"

I think it will be a good idea to have the same button label on both cases, it will add consistency to the feature.

Comment 1

[Vijay Budhram]

:rfeeley, are you good with making this change on the toolbar?

Comment 2

[Vijay Budhram]

Spoke with :rfeeley over slack and confirmed that the buttons should be different. However, there are some styling inconsistencies between the two panels that need to be resolved. I will spin that out into a new bug though.