1573190 - Triggering WebAuthn spawns a system notification for every unfocused Firefox window on Linux

Status: RESOLVED DUPLICATE of bug 1540309

(Core :: DOM: Web Authentication, defect, P2)

Description

[Dan Callahan [:callahad]]

Attachment: Screenshot from 2019-08-12 16-29-14.png

Steps to Reproduce:

1. Visit https://webauthn.me/debugger and click the big purple "Register" button

What Should Happen:

1. The WebAuthn doorhanger appears in the webauthn.me window

What Actually Happens:

1. The doorhanger appears, and...
2. A system notification appears for every unfocused Firefox window, alerting me that it's "ready"

This causes significant UI clutter if many Firefox windows are open.

I'm using Gnome 3.32

Comment 1

[J.C. Jones [:jcj] (he/they)]

Fascinating. Johann, is this something that would be fixed by Bug 1540309?

Comment 3

[Johann Hofmann [:johannh]]

Yeah, pretty sure it would be :)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jcj, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Arjen Lentz]

It'd be great to see this resolved.
With more hardware MFA being used, this is becoming increasingly important.
While technically harmless, it's a UI/UX pain.
For instance, the state causes all Firefox windows on the desktop's taskbar to blink, and keep blinking until each of them is visited (focused) in turn.

Comment 6

[J.C. Jones [:jcj] (he/they)]

I'll try again to fix up the patch in Bug 1540309. It fixes the issue, but I had a lot of trouble writing the test, as I'm just not as familiar with writing UI tests. I'm sorry for the delay, thanks for pinging.

Comment 7

[J.C. Jones [:jcj] (he/they)]

OK, I figured out the tests, so I'll shortly have that in the review queue for Nightly. I'll report back when it's in Nightly for you to test, and then hopefully I can resolve this as a dupe of Bug 1540309.

Comment 8

[Arjen Lentz]

Awesome JC, looking forward to it and happy to verify with a Nightly.

Comment 9

[J.C. Jones [:jcj] (he/they)]

This should be in one of Tuesday's Nightlies; it landed as https://hg.mozilla.org/integration/autoland/rev/b4b7e943b93c . I'll post which version tomorrow!

Comment 10

[J.C. Jones [:jcj] (he/they)]

Please give tonight's Nightly (or later) a try and see if it solves the issue.

Comment 11

[Arjen Lentz]

Sorry JC, I didn't get a chance to grab a nightly and test this for you.
However, the good news is that it does seem properly fixed now, Firefox 83.0 does not have the problem.
I presume that others confirmed that it was fixed and you let through the fix to the next release?
If that's all correct, then I think we can mark this issue as resolved!

Horays, well done, and thanks a lot - it makes people here very happy!
rock on.

Kind regards,
Arjen.