remove the email validation for metadata.owner
Categories
(Taskcluster :: Services, enhancement)
Tracking
(Not tracked)
People
(Reporter: mtabara, Assigned: mtabara)
Details
Attachments
(1 file)
In https://github.com/mozilla/application-services/ and https://github.com/mozilla-mobile/android-components/ there's various github apps which run (e.g. https://dependabot.com/ or https://github.com/bors-ng/bors-ng).
When taskcluster-github is rendering the .taskcluster.yml, it hits some email validation errors in setting up metadata.owner which normally is set to ${user}@users.noreply.github.com where user = ${event.sender.login}. For primitive github operations, sans bots, this works well while for cron-jobs triggered from hooks, we feed that value to our covenience. However, for bots, we may not always have that flexibility of tweaking the bot input. Moreover, Github itself is adding the [bot] string to that input.
In order to make checks such as this and this more generic (if we end up adding multiple bots for a repo), there might be a couple of solutions at hand.
a) add a string.replace operation in json-e which would ensure the string.replace("[bot]", "") solves regardless of the bot name
b) remove the email validation for metadata.owner
As far as I understood, the latter is something that TC team has been considering in the past.
|
||
Comment 1•6 years ago
|
||
Thanks for filing a bug. We discussed this in today's team meeting, and from what we know it's fine to just go ahead with (b).
However, it's hard to know how things are used in Taskcluster, and our process for making potentially-breaking changes involves RFCs. These give a chance for lots of people to see and understand the proposed change and chime in if they see an issue that we do not.
So, can you create a TC RFC for this change and shepherd it through the proposal and final-comment phases? The RFC itself doesn't have to be very long -- in fact, you've covered the necessary points in comment 0 so some editing of that into the RFC template would probably do the trick.
|
Assignee | |
Comment 2•6 years ago
|
||
Sorry, this slipped my radar somehow before the PTO at the end of August. I'Il take care of this this week or the next.
Creating an TC RFC sounds gopod, thanks for suggesting this :dustin!
|
|
||
Comment 3•6 years ago
|
||
I still think this is a good idea, and it should be fairly quick to get agreement on it.
|
|
Assignee | |
Comment 4•6 years ago
|
||
(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #3)
I still think this is a good idea, and it should be fairly quick to get agreement on it.
RFC - https://github.com/taskcluster/taskcluster-rfcs/pull/153
|
|
Assignee | |
Updated•6 years ago
|
|
|
||
Comment 5•6 years ago
|
||
Mihai, will you be making the patch for this? It should be short and I can do so too if you'd prefer.
|
|
Assignee | |
Comment 6•6 years ago
|
||
(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #5)
Mihai, will you be making the patch for this? It should be short and I can do so too if you'd prefer.
I'd love to do it as I'd like to dig a bit in the taskcluster codebase. My plate is a bit full before the holidays but I'm planning to get to it either before X-mas or on the 30-31 December which should be perfect quiet working days for hacking on such things.
Should there is an urgency on implementing this, I'm happy to defer.
|
|
Assignee | |
Comment 7•6 years ago
|
||
|
||
Comment 8•6 years ago
|
||
Any luck? We're also seeing this on xpi repos due to bors commits. https://github.com/mozilla-extensions/normandy-devtools/commit/9962634f17c21faca0a352014ec1b0780907ac86
|
|
||
Comment 9•6 years ago
|
||
Merged! This will be in v27.
|
|
Assignee | |
Comment 10•6 years ago
|
||
(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #9)
Merged! This will be in v27.
Thank you, closing this.
Description
•