1573204 - Discovery Stream pocket stories add one more line to text content

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

To test:

1. Open a new tab
2. Ensure we see pocket stories with at max 4 lines of text.
3. Ensure cards in a single row are all the same height, based on the height of the tallest card.

Comment 1

[Scott [:thecount] Downe]

Right now in Discovery Stream we have 3 possible lines we can display in a story, and after that the text gets "..." We want to up it to 4 possible lines of text.

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: UX and partners concerns.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5247

Comment 4

[Scott [:thecount] Downe]

Attachment: Uplift 1573204 - Adding an extra line to pocket stories

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 9084910 [details]
Uplift 1573204 - Adding an extra line to pocket stories

Beta/Release Uplift Approval Request

• User impact if declined: Revenue impact for sponsored content clients not getting the rows they expected.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test:

1. Open a new tab
2. Ensure we see pocket stories with at max 4 lines of text.
3. Ensure cards in a single row are all the same height, based on the height of the tallest card.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's 2 lines of CSS, once verified on nightly it should be low risk.
• String changes made/needed: none

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7d5723904550

Comment 7

[Scott [:thecount] Downe]

There was a decision made to not have this done in 69 after all.

Comment 8

[Patriciu Pop [:ppop], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (70.0a1 Build ID - 20190815193505) installed, on Windows 10 x64, Ubuntu 16.04 and Mac 10.14.6. I can confirm that a maximum of 4 lines of text are displayed and all cards in a single row are at the same height.