Closed Bug 1573229 Opened 4 months ago Closed 4 months ago

Make memory allocation functions in HyphenReporter infallible, as assumed by libhyphen

Categories

(Core :: Layout: Text and Fonts, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

In bug 1567437, we added memory reporting for libhyphen, by replacing its direct use of moz_xmalloc and friends with a CountingAllocator. However, this had the inadvertent side-effect of changing from infallible to fallible allocation, which is not safe; the libhyphen code assumes an infallible allocator.

So we need to ensure the HyphenReporter allocation functions are infallible.

Attachment #9084809 - Attachment description: Bug 1573229 - Make memory allocation functions in HyphenReporter infallible. r=njn → Bug 1573229 - part 2 - Make memory allocation functions in HyphenReporter infallible. r=njn

:njn - was there something further you wanted tweaked in part 1? Phabricator says "requested changes" but I don't see any new comment...

Flags: needinfo?(n.nethercote)
Flags: needinfo?(n.nethercote)

D'uh - sorry, clearly a lack of coffee or something! Will update.

Attachment #9085003 - Attachment description: Bug 1573229 - part 1 - Add infallible wrappers for the memory-allocation functions in CountingAllocatorBase. r=njn → Bug 1573229 - part 1 - Add infallible versions of the memory-allocation functions in CountingAllocatorBase. r=njn
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fd3531df50e
part 1 - Add infallible versions of the memory-allocation functions in CountingAllocatorBase. r=njn
https://hg.mozilla.org/integration/autoland/rev/f1d84baef0c3
part 2 - Make memory allocation functions in HyphenReporter infallible. r=njn
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → jfkthame
You need to log in before you can comment on or make changes to this bug.