Make memory allocation functions in HyphenReporter infallible, as assumed by libhyphen
Categories
(Core :: Layout: Text and Fonts, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
In bug 1567437, we added memory reporting for libhyphen, by replacing its direct use of moz_xmalloc and friends with a CountingAllocator. However, this had the inadvertent side-effect of changing from infallible to fallible allocation, which is not safe; the libhyphen code assumes an infallible allocator.
So we need to ensure the HyphenReporter allocation functions are infallible.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
:njn - was there something further you wanted tweaked in part 1? Phabricator says "requested changes" but I don't see any new comment...
|
||
Comment 4•5 years ago
|
||
This comment: https://phabricator.services.mozilla.com/D41720#1257899
|
|
Assignee | |
Comment 5•5 years ago
|
||
D'uh - sorry, clearly a lack of coffee or something! Will update.
|
|
||
Updated•5 years ago
|
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fd3531df50e part 1 - Add infallible versions of the memory-allocation functions in CountingAllocatorBase. r=njn https://hg.mozilla.org/integration/autoland/rev/f1d84baef0c3 part 2 - Make memory allocation functions in HyphenReporter infallible. r=njn
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3fd3531df50e
https://hg.mozilla.org/mozilla-central/rev/f1d84baef0c3
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•2 years ago
|
Description
•