1573229 - Make memory allocation functions in HyphenReporter infallible, as assumed by libhyphen

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P2)

Description

[Jonathan Kew [:jfkthame]]

In bug 1567437, we added memory reporting for libhyphen, by replacing its direct use of moz_xmalloc and friends with a CountingAllocator. However, this had the inadvertent side-effect of changing from infallible to fallible allocation, which is not safe; the libhyphen code assumes an infallible allocator.

So we need to ensure the HyphenReporter allocation functions are infallible.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1573229 - part 2 - Make memory allocation functions in HyphenReporter infallible. r=njn

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1573229 - part 1 - Add infallible versions of the memory-allocation functions in CountingAllocatorBase. r=njn

Comment 3

[Jonathan Kew [:jfkthame]]

:njn - was there something further you wanted tweaked in part 1? Phabricator says "requested changes" but I don't see any new comment...

Comment 4

[Nicholas Nethercote [inactive]]

This comment: https://phabricator.services.mozilla.com/D41720#1257899

Comment 5

[Jonathan Kew [:jfkthame]]

D'uh - sorry, clearly a lack of coffee or something! Will update.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fd3531df50e
part 1 - Add infallible versions of the memory-allocation functions in CountingAllocatorBase. r=njn
https://hg.mozilla.org/integration/autoland/rev/f1d84baef0c3
part 2 - Make memory allocation functions in HyphenReporter infallible. r=njn

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3fd3531df50e
https://hg.mozilla.org/mozilla-central/rev/f1d84baef0c3