1573242 - fixing scaling for line thickness padding in text-decoration-skip-ink

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Charlie Marlow [:cmarlow]]

We pad the thickness of the line that is passed into Skia so that the underline isn't touching text that is ~1px or less above/below it. Right now it scales with thickness, but this means that an incorrect line is passed into Skia whenever the thickness is very large. To fix this, there should be a clamp so that the lineThicknessPadding is never greater than 1 pixel.

Comment 1

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1573242: fixed scaling issue for line thickness padding r?jfkthame

Comment 2

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4ee9597a69c81dd132b4603383cd583a10dfb676&selectedJob=261427255

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/828e2e9b86e8
fixed scaling issue for line thickness padding r=jfkthame

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/828e2e9b86e8