1573248 - DiscoveryStream layout spocs_per_domain not followed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

There is a server returned prop for spocs_per_domain which allows multiple spocs to be shown from the same domain.

There is a bug now which causes that to not be used, and it defaults to 1.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5245

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/ea3eebc73ccb

Comment 3

[Scott [:thecount] Downe]

To test:

1. Set http://browser.newtabpage.activity-stream.asrouter.devtoolsenabled/ to true
2. Go to about:home#devtools-ds
3. Deselect hardcoded_layout
4. Ensure show_spocs is set
5. Under endpoint variant, toggle on staging_spocs
6. Go to about:home
7. Expected, see if any of the first few cards are sponsored by the same company.

This can produce false positives if the staging server happens to be returning all unique spocs at that moment. I'll see if I can find a better way to verify.

To verify a false positive, you can scroll down to the bottom of "about:home#devtools-ds" and look at what's in "Spoc data", if it matches what you're seeing, then the server simply returned no dupes for us to enable.

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox 69.0 rc2 (Build ID - 20190829214656) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the first three displayed cards are sponsored by the same company.
Thank you, Scott, for the steps from above :).