1573254 - Support remote windows in SpecialPowers.snapshotWindow

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[Kris Maglione [:kmag]]

A lot of the tests that currently use the snapshotWindow API do so with cross-origin windows. Under Fission, these windows are also cross-process, and cannot be captured with the current API.

The most straightforward way to handle these windows is to take the snapshot in the process that owns the window, and return the ImageData. This would make the API asynchronous, and require that it return a promise.

Unfortunately, a lot of the existing callers are timing-sensitive, and can't easily be migrated to use an async API. So my plan is to simply return a synchronous snapshot when given an in-process window, and to return a promise in all other cases.

Ideally we'd just have separate sync and async APIs, but given the number of existing callers, I don't think it's worth the effort to migrate them all.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1573254: Part 1 - Support remote windows in SpecialPowers.snapshotWindow. r=mccr8

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1573254: Part 2 - Update tests to await snapshotWindow when necessary. r=mccr8

This fixes several tests which snapshot remote windows under Fission. It also
changes some other arbitrary tests that don't use remote windows, which I
changed before I gave up on having an always-async API.

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3db0f8fbc5b2ac742da75e8295052d5d9510306
Bug 1573254: Part 1 - Support remote windows in SpecialPowers.snapshotWindow. r=mccr8

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b826e607ca87939b656b62836721973c67dac71
Bug 1573254: Part 2 - Update tests to await snapshotWindow when necessary. r=mccr8

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/504f777152d8c38d2ac11577da8b1cf84fd8524d
Bug 1573254: Follow-up: Fix bustage after rebase. r=bustage,test-only

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c3db0f8fbc5b
https://hg.mozilla.org/mozilla-central/rev/4b826e607ca8
https://hg.mozilla.org/mozilla-central/rev/504f777152d8