Add %SystemRoot% to whitelisted paths for PreparePathForTelemetry
Categories
(Core :: Widget: Win32, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
6.53 KB,
text/plain
|
chutten|PTO
:
data-review+
|
Details |
This is another directory that we may consider "safe," and since many DLLs are loaded from there, we should allow paths beginning with %SystemRoot%
.
Assignee | ||
Comment 1•6 years ago
|
||
Until now, WinUtils::PreparePathForTelemetry
did not whitelist paths
originating from the Windows system directory. This is unfortunate, as those
paths are not going to contain any PII yet may be useful for troubleshooting.
By adding %SystemRoot%
to the whitelist, such paths will be included after
substituting the real system directory with the name of the environment
variable.
I also took this opportunity to do some cleanup in the way the array of
whitelist entries is managed.
Assignee | ||
Comment 2•6 years ago
|
||
Since this adds an additional whitelisted path to untrusted modules telemetry, I am submitting the untrusted modules data review request, augmented to reflect the changes in this patch.
Comment 3•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 5•6 years ago
|
||
bugherder |
Description
•