1573285 - Add pref extensions.systemAddon.update.enabled;true to get Fennec SAOs update working

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

While we were discussing Fennec SAO updates not working at a webcompat meeting, I realized that Firefox desktop has a pref called extensions.systemAddon.update.enabled;true but my Fennec release/beta don't have a similar pref.

This pref should be added to Fennec as it's needed for SAO updates via balrog to work.

MTaylor tried to add that pref locally to his Fennec and got the webcompat 5.0.2 SAO working.

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Mike, could you please add STR and logs to this bug?

Comment 2

[Mike Taylor [:miketaylr]]

1. download new Firefox for Android from Google Play Store (68.0 -- it has to be release, Beta and Nightly have 5.0.2 SAO via uplift)
2. verify via about:support that Web Compat SAO is 4.3.2
3. go to about:config
4. add extensions.systemAddon.update.enabled = true
5. enable remote debugging via (Firefox for Android) Settings > Advanced
6. Open WebIDE via (Firefox) Tools > Web Developer > WebIDE
7. Select about:support tab (or any other, I dunno, the next step complained when I tried from the main thread)
8. dump Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck(); into console
9. wait a second, hit refresh on about:support

Now the WebCompat system addon is 5.0.2

The following was logged (I had extensions.logging.enabled=true set):

1565643246727 addons.manager DEBUG Background update check beginning
1565643246753 addons.repository DEBUG Repopulate add-on cache with ["[e-mail]", "[e-mail]", "gmp-gmpopenh264"]
1565643248018 addons.repository DEBUG Cache repopulated, setting extensions.getAddons.cache.lastUpdate to 1565643248
1565643248028 addons.xpi-utils DEBUG updateAddonRepositoryData found 2 visible add-ons
1565643248030 addons.manager DEBUG onUpdateFinished for gmp-gmpopenh264
1565643248077 addons.xpi INFO Starting system add-on update check from https://aus5.mozilla.org/update/3/SystemAddons/68.0/20190705221915/Android_aarch64-gcc3/en-US/release/Linux%2028/default/default/update.xml.
1565643248082 addons.productaddons INFO sending request to: https://aus5.mozilla.org/update/3/SystemAddons/68.0/20190705221915/Android_aarch64-gcc3/en-US/release/Linux%2028/default/default/update.xml
1565643249053 addons.productaddons INFO Completed downloading document
1565643250362 addons.productaddons INFO downloadXHR File download. status=200
1565643250370 addons.productaddons INFO Downloaded file will be saved to /data/user/0/org.mozilla.firefox/app_tmpdir/tmpaddon
1565643250547 addons.xpi INFO Installing new system add-on set
1565643250591 addons.repository DEBUG cacheAddons: enabled true IDs ["[e-mail]"]
1565643250617 addons.xpi DEBUG Starting install of [e-mail] from file:///data/user/0/org.mozilla.firefox/app_tmpdir/tmpaddon
1565643250618 addons.manager DEBUG Background update check complete
1565643250623 addons.xpi DEBUG Addon [e-mail] will be installed as a packed xpi
1565643250627 addons.xpi DEBUG Calling bootstrap method shutdown on [e-mail] version 4.3.2
1565643250645 addons.xpi-utils DEBUG Updating active state for add-on [e-mail] to false
1565643250646 addons.xpi-utils DEBUG Make addon app-system-addons:[e-mail] visible
1565643250646 addons.xpi-utils DEBUG Hide addon app-system-defaults:[e-mail]
1565643250647 addons.xpi DEBUG Updating XPIState for {"id":"[e-mail]","syncGUID":"{e26072e0-c754-45da-9732-d4a9edf6478b}","version":"4.3.2","type":"extension","loader":null,"updateURL":null,"optionsURL":null,"optionsType":null,"optionsBrowserStyle":true,"aboutURL":null,"defaultLocale":{"name":"Web Compat","description":"Urgent post-release fixes for web compatibility.","creator":null,"developers":null,"translators":null,"contributors":null},"visible":false,"active":false,"userDisabled":false,"appDisabled":false,"installDate":1565642807000,"updateDate":1565642807000,"applyBackgroundUpdates":1,"path":"/data/user/0/org.mozilla.firefox/features/[e-mail]","skinnable":false,"sourceURI":null,"releaseNotesURI":null,"softDisabled":false,"foreignInstall":false,"strictCompatibility":true,"locales":[],"targetApplications":[{"id":"[e-mail]","minVersion":"59.0b5","maxVersion":null}],"targetPlatforms":[],"seen":true,"dependencies":[],"incognito":"spanning","userPermissions":{"permissions":["webRequest","webRequestBlocking"],"origins":["<all_urls>"]},"icons":{},"iconURL":null,"blocklistState":0,"blocklistURL":null,"startupData":null,"hidden":true,"installTelemetryInfo":null,"recommendationState":null,"rootURI":"jar:file:///data/user/0/org.mozilla.firefox/features/[e-mail]!/","location":"app-system-defaults"}
1565643250648 addons.xpi DEBUG XPIStates adding add-on [e-mail] in {"addons":{},"staged":{},"path":"/data/user/0/org.mozilla.firefox/files/mozilla/0nwllmnk.default/features/{a9dd0a15-36b8-4afe-9e63-982b4ded7421}"}: /data/user/0/org.mozilla.firefox/files/mozilla/0nwllmnk.default/features/{a9dd0a15-36b8-4afe-9e63-982b4ded7421}/[e-mail]
1565643250649 addons.xpi DEBUG Updating XPIState for {"id":"[e-mail]","syncGUID":"{65bd11f0-ff53-49e6-ba18-9a63683a0441}","version":"5.0.2","type":"extension","loader":null,"updateURL":null,"optionsURL":null,"optionsType":null,"optionsBrowserStyle":true,"aboutURL":null,"defaultLocale":{"name":"Web Compat","description":"Urgent post-release fixes for web compatibility.","creator":null,"developers":null,"translators":null,"contributors":null},"visible":true,"active":true,"userDisabled":false,"appDisabled":false,"installDate":1565642807000,"updateDate":1565643250612,"applyBackgroundUpdates":1,"path":"/data/user/0/org.mozilla.firefox/files/mozilla/0nwllmnk.default/features/{a9dd0a15-36b8-4afe-9e63-982b4ded7421}/[e-mail]","skinnable":false,"sourceURI":"file:///data/user/0/org.mozilla.firefox/app_tmpdir/tmpaddon","releaseNotesURI":null,"softDisabled":false,"foreignInstall":false,"strictCompatibility":true,"locales":[],"targetApplications":[{"id":"[e-mail]","minVersion":"59.0b5","maxVersion":null}],"targetPlatforms":[],"signedState":3,"seen":true,"dependencies":[],"incognito":"spanning","userPermissions":{"permissions":["webRequest","webRequestBlocking"],"origins":["<all_urls>"]},"icons":{},"iconURL":null,"blocklistState":0,"blocklistURL":null,"startupData":null,"hidden":true,"installTelemetryInfo":null,"recommendationState":null,"rootURI":"jar:file:///data/user/0/org.mozilla.firefox/files/mozilla/0nwllmnk.default/features/%7Ba9dd0a15-36b8-4afe-9e63-982b4ded7421%7D/[e-mail]!/","location":"app-system-addons"}
1565643250650 addons.xpi DEBUG Install of file:///data/user/0/org.mozilla.firefox/app_tmpdir/tmpaddon completed.
1565643250651 addons.xpi DEBUG Loading bootstrap scope from jar:file:///data/user/0/org.mozilla.firefox/files/mozilla/0nwllmnk.default/features/%7Ba9dd0a15-36b8-4afe-9e63-982b4ded7421%7D/[e-mail]!/
1565643250651 addons.xpi DEBUG Calling bootstrap method update on [e-mail] version 5.0.2
1565643250651 addons.xpi DEBUG Calling bootstrap method startup on [e-mail] version 5.0.2
1565643250746 addons.xpi DEBUG removeTemporaryFile: file:///data/user/0/org.mozilla.firefox/app_tmpdir/tmpaddon removing temp file /data/user/0/org.mozilla.firefox/app_tmpdir/tmpaddon
1565643251046 addons.xpi-utils DEBUG XPI Database saved, setting schema version preference to 31

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: Bug 1573285 - set system add-on enable pref on by default for Fennec r?snorp

This was originally added in bug 1428459 to separate system add-on updates from app updates, but the pref only made it to desktop and not mobile.

Comment 4

[Mike Taylor [:miketaylr]]

[Tracking Requested - why for this release]: Once this lands, we should consider a dot release ridealong uplift for Fennec (sorry, not sure if we should use the esr flag for Fennec instead).

Comment 5

[Julien Cristau [:jcristau]]

Yes, let's use the esr flag.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4030fa4ee5
set system add-on enable pref on by default for Fennec r=snorp

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5b4030fa4ee5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta & ESR68 approval when you get a chance.

Comment 9

[Robert Helmer [:rhelmer]]

Attachment: Uplift requests for Bug 1573285

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a toggle to a single pref, extensions.systemAddon.update.enabled, to enabled system add-ons on Fennec.
• User impact if declined: Mozilla will be unable to push webcompat or hotfixes outside of the normal Fennec release cycle.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature is in-use on desktop and has been tested in this bug on Fennec.
• String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

• User impact if declined: Mozilla will be unable to push webcompat or hotfixes outside of the normal Fennec release cycle.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature is in-use on desktop and has been tested in this bug on Fennec.
• String changes made/needed:

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 9087126 [details]
Uplift requests for Bug 1573285

>Uplift requests for Bug 1573285

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085159 [details]
Bug 1573285 - set system add-on enable pref on by default for Fennec r?snorp

Enables system addons for Fennec. Approved for 68.1b8.

Comment 12

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/b0109dd26903

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/18bcc03292a5