1573304 - Add GeckoRuntimeSettings.debugLogging() function to control logging

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Randall Barker [:rbarker]]

Currently there is no way to control gecko console service and GeckoView JSM logging. It is important for app to be able to control the logging output.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1573304 - Add GeckoRuntimeSettings.debugLogging() function to control logging

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84f5ba056710
Add GeckoRuntimeSettings.debugLogging() function to control logging r=geckoview-reviewers,agi,snorp

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/84f5ba056710

Comment 4

[Chris Peterson [:cpeterson]]

Randall, should we uplift your debugLogging API to GV 69 Beta? Is debug logging enabled or disabled by default? Will Fenix need to explicitly call this API in their production builds?

Comment 5

[Randall Barker [:rbarker]]

If it hasn't been a problem up to now, they probably don't need it now. This was mostly needed because FxR uses nightly. The patch doesn't change the default behavior. I just gives a way to override the default behavior.

Comment 6

[Chris Peterson [:cpeterson]]

Thanks. I'm setting 69=wontfix because we don't need to uplift.

Since logging is still enabled by default and GV doesn't know whether the app build is a local or production build, I filed a Fenix issue asking them to call debugLogging appropriately: https://github.com/mozilla-mobile/fenix/issues/4763

Comment 7

[Chris Peterson [:cpeterson]]

Fenix will use this new debugLogging API to disable logging after they update to GV 70: https://github.com/mozilla-mobile/fenix/issues/4763