Closed Bug 1573304 Opened 3 months ago Closed 3 months ago

Add GeckoRuntimeSettings.debugLogging() function to control logging

Categories

(GeckoView :: General, enhancement)

Unspecified
All
enhancement
Not set

Tracking

(firefox68 wontfix, firefox69 wontfix, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: rbarker, Assigned: rbarker)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Currently there is no way to control gecko console service and GeckoView JSM logging. It is important for app to be able to control the logging output.

Assignee: nobody → rbarker
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84f5ba056710
Add GeckoRuntimeSettings.debugLogging() function to control logging r=geckoview-reviewers,agi,snorp
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Randall, should we uplift your debugLogging API to GV 69 Beta? Is debug logging enabled or disabled by default? Will Fenix need to explicitly call this API in their production builds?

Flags: needinfo?(rbarker)

If it hasn't been a problem up to now, they probably don't need it now. This was mostly needed because FxR uses nightly. The patch doesn't change the default behavior. I just gives a way to override the default behavior.

Flags: needinfo?(rbarker)

Thanks. I'm setting 69=wontfix because we don't need to uplift.

Since logging is still enabled by default and GV doesn't know whether the app build is a local or production build, I filed a Fenix issue asking them to call debugLogging appropriately: https://github.com/mozilla-mobile/fenix/issues/4763

Fenix will use this new debugLogging API to disable logging after they update to GV 70: https://github.com/mozilla-mobile/fenix/issues/4763

You need to log in before you can comment on or make changes to this bug.