Pressing Back on premium content requires you to log in again
Categories
(Toolkit :: Reader Mode, defect)
Tracking
()
People
(Reporter: tech4pwd, Unassigned, NeedInfo)
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0
Steps to reproduce:
If you go to a site with Premium Content, enter Reader Mode, follow a link to another article and then press back...
Actual results:
Reader Mode asks you to log in again.
Expected results:
As used to be the case, it used to load the content from cache (or fetch your cookies), not treat you as a logged out user.
|
Reporter | |
Comment 1•6 years ago
|
||
Also, another thing that's indicative of this issue is that if you're logged into a site and leave the page on Reader Mode and then restart the browser, when the browser restarts, you'll be asked to log in once again. Even though if you click back, you'll find you're already logged in.
|
||
Comment 2•6 years ago
|
||
This really needs an example site and more details.
(In reply to Paul [pwd] from comment #0)
As used to be the case, it used to load the content from cache (or fetch your cookies), not treat you as a logged out user.
I don't think navigating from page A back to reader mode for page B ever used to do this, but if you can find a regression window that would help.
|
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #2)
This really needs an example site and more details.
(In reply to Paul [pwd] from comment #0)
As used to be the case, it used to load the content from cache (or fetch your cookies), not treat you as a logged out user.
I don't think navigating from page A back to reader mode for page B ever used to do this, but if you can find a regression window that would help.
Going from Page A (Reader) -> Page B <- Page A (Reader) 100% used to just reload the page and not require users to log in to something that they're already logged in to. I'm not even sure of the mental gymnastics required to suggest that a page you're logged in shouldn't treat you as such when in Reader Mode.
|
|
Reporter | |
Comment 4•6 years ago
|
||
I'll find some time later to try and find a regression window.
|
|
||
Comment 5•6 years ago
|
||
(In reply to Paul [pwd] from comment #3)
(In reply to :Gijs (he/him) from comment #2)
This really needs an example site and more details.
(In reply to Paul [pwd] from comment #0)
As used to be the case, it used to load the content from cache (or fetch your cookies), not treat you as a logged out user.
I don't think navigating from page A back to reader mode for page B ever used to do this, but if you can find a regression window that would help.
Going from Page A (Reader) -> Page B <- Page A (Reader) 100% used to just reload the page and not require users to log in to something that they're already logged in to. I'm not even sure of the mental gymnastics required to suggest that a page you're logged in shouldn't treat you as such when in Reader Mode.
No need to be rude about "mental gymnastics". We're talking about different kinds of "cache". There's a so-called bfcache ( https://developer.mozilla.org/en-US/docs/Archive/Misc_top_level/Working_with_BFCache gives the general idea even if it's out-of-date), and we try to use that for going from any page to its reader mode version and back. Going from some other page to a reader copy of a different page may or may not use it; it will depend on some of the other specifics, I expect.
As for regular network cache, I expect it depends on the site's cache headers and the longevity of cookies, but nothing material has changed about the relevant code ( https://hg.mozilla.org/mozilla-central/log/tip/toolkit/components/reader/ReaderMode.jsm?patch=&linerange=247:348 ) for quite a while. It could still be a regression, of course, but likely to do with something else (like network/cache code itself). A range and/or a specific site example would really help.
|
||
Comment 6•6 years ago
|
||
Hey Paul, I'm closing this bug as resolved-incomplete since the needinfo has been open for over 14 days. Please reopen the bug when you respond to the needinfo or if you have better steps-to-reproduce.
Description
•