1573456 - Add unit test to check that moz-extension: redirect by webRequest is loaded in the correct process

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P2)

Description

[Rob Wu [:robwu]]

Attachment: webRequest-redirect-to-extension.zip

STR:

1. Load the attached extension.
2. Navigate to https://example.com/redir (or click on the extension button).
3. (the extension will use the webRequest API to redirect the request to a web-accessible moz-extension page).
4. Look at the page.

Expected:

• "events,types,browserAction,tabs,windows,extensionTypes,contentScripts,management,permissions,theme,experiments,webRequest,extension,i18n,runtime,test"
  (this shows that the page is loaded in the extension process)

Actual:

• "extension,i18n,runtime,test"
  (the page is loaded in a web content process, gBrowser.selectedBrowser.remoteType is "web" instead of "extension"; checking the process ID in the content toolbox also shows that the page itself is loaded in the wrong process)

This is not a recent regression. It happens on Nightly 70, release 68.0.1, Firefox 60 (tested on Linux).

When the tab is reloaded or duplicated, the page is loaded in the expected process.

Comment 1

[Jim Mathies [:jimm]]

We're hoping this will get fixed via fission changes (assuming it's not already fixed).

Comment 2

[Rob Wu [:robwu]]

With fission.autostart=true, this bug goes away.

Comment 4

[Rob Wu [:robwu]]

This issue has been fixed since Firefox 72 by bug 1584031 (https://hg.mozilla.org/mozilla-central/rev/7a1d40167829), but regresseed briefly in 73 (https://bugzilla.mozilla.org/show_bug.cgi?id=1561711#c8), so we should add a unit test.

Comment 5

[William Durand [:willdurand]]

Attachment: Bug 1573456 - Add xpcshell test case to check that moz-extension: redirect by webRequest is loaded in the correct process. r=robwu

Comment 6

[William Durand [:willdurand]]

Attachment: Bug 1573456 - Add browser test to check that moz-extension: redirect by webRequest is loaded in the correct process. r=robwu

Depends on D68608

Comment 7

[Rob Wu [:robwu]]

Thanks for taking over Will!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a6011666e5f
Add browser test to check that moz-extension: redirect by webRequest is loaded in the correct process. r=robwu

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8a6011666e5f