1573569 - Crash in [@ mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds]/[@ mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds ]

Status: RESOLVED WONTFIX

(Core :: Graphics: Layers, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-fc73c93d-ace9-48fa-b039-6e7d30190623.

Spinning this out of Bug 1506637, since the signature is noticeable on both 69 nightly and the current 70 nightly: https://mzl.la/2MfqIVZ

The first crashes in 69 nightly were in 20190623094201 - based on that a possible regression range might be https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e729bfa4f60157a8e8ed9cd3ae5f9d854ab7f7f3&tochange=a8c21ee98a4c2f683335b8358c11b2fceb863f05

Bug 1557093 is in that range, and I see some code was touched. ni on : nhnt11

(100.0% in signature vs 00.30% overall) address = 0x318
(29.27% in signature vs 00.22% overall) Module "sophos_detoured_x64.dll" = true [100.0% vs 00.61% if platform_version = 10.0.17134]
(90.24% in signature vs 09.05% overall) Module "dcomp.dll" = true [100.0% vs 15.10% if platform_version = 10.0.17134]
(46.34% in signature vs 06.07% overall) CPU Info = family 6 model 42 stepping 7
(70.73% in signature vs 33.27% overall) plugin_name = null
(29.27% in signature vs 66.06% overall) abort_message = null
(76.83% in signature vs 23.75% overall) ipc_channel_error = null [29.27% vs 66.54% if process_type = gpu]
(90.24% in signature vs 61.32% overall) Module "win32u.dll" = true
(19.51% in signature vs 04.08% overall) Addon "[e-mail]" = true

Top 10 frames of crashing thread:

0 xul.dll void mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp
1 xul.dll static class mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:103
2 xul.dll static class mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:127
3 xul.dll static class mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:127
4 xul.dll void mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:157
5 xul.dll bool mozilla::layers::FrameBuilder::Build gfx/layers/mlgpu/FrameBuilder.cpp:69
6 xul.dll void mozilla::layers::LayerManagerMLGPU::RenderLayers gfx/layers/mlgpu/LayerManagerMLGPU.cpp:369
7 xul.dll void mozilla::layers::LayerManagerMLGPU::Composite gfx/layers/mlgpu/LayerManagerMLGPU.cpp:323
8 xul.dll void mozilla::layers::LayerManagerMLGPU::EndTransaction gfx/layers/mlgpu/LayerManagerMLGPU.cpp:278
9 xul.dll void mozilla::layers::CompositorBridgeParent::CompositeToTarget gfx/layers/ipc/CompositorBridgeParent.cpp:1012

Comment 1

[Lee Salzman [:lsalzman]]

Jeff, it looks like the clipped draw target API changes were in this range, could they have impacted this?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Yep. It's possible.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Clearing needinfo, I took a look and don't really have any knowledge that would be useful here. The change in bug 1557093 was a simple change of what type of click we're handling to open a panel - furthermore, that code has since been replaced.

Comment 4

[Marcia Knous [:marcia]]

This is still happening pretty regularly on nightly, with anywhere from 4 - 16 crashes per nightly build. There are no comments and no URLs.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

I put up a debugging patch here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efdbc95665dfb76eee6f136561c68ea36abe20c3

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1573569. Add some debugging code.

This should help us figure what's going on.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/842d11907cbe
Add some debugging code. r=aosmond

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/842d11907cbe

Comment 9

[Jeff Muizelaar [:jrmuizel]]

I moved the crash to mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds

Comment 10

[Jeff Muizelaar [:jrmuizel]]

We're getting a RefLayer instead of a ContainerLayer

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Jeff, do you have more data now that could help solve this crash? The volume on Nightly is still concerning, I would probably take an uplift to beta if it can't be fixed in Nightly. Thanks.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

These crashes seem to mostly (97%) be fission related. I don't think this is something we need to worry about in the short term.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Thanks, marking as fix-optional for 71 then!

Comment 14

[Nicolas Silva [:nical]]

Looks like the crashes are now in bug 1588484.

Comment 15

[Andrew McCreight [:mccr8]]

This is one of the more common Fission crash signatures, though there were about 80 crashes from only 14 different installations.

Comment 16

[Andrew McCreight [:mccr8]]

Never mind. I was looking at the wrong query, and it does look like bug 1588484 made this go away for Fission.

Comment 17

[Pascal Chevrel:pascalc (PTO until April 26)]

The crashes for this signature are back on Nightly since last week.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

Crashes are with Fission enabled, marking beta/release as disabled

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jrmuizel, maybe it's time to close this bug?

Comment 21

[Jeff Muizelaar [:jrmuizel]]

Sure.