Closed Bug 1573700 Opened 4 years ago Closed 4 years ago

Port gfx/gl/GLParseRegistryXML.py to python3

Categories

(Core :: Graphics, task, P3)

Product:
Core
Component:
Graphics
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1573700 - s/GLParseRegistryXML.py/GLConsts.py/ and port to python3+mypy.
47 bytes, text/x-phabricator-request
Details | Review

Python2 EOL is in 2020.

Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42cdb2c4c768
s/GLParseRegistryXML.py/GLConsts.py/ and port to python3+mypy. r=lsalzman

Backed out changeset 42cdb2c4c768 (bug 1573700) for flake8 failure at builds/worker/checkouts/gecko/gfx/gl/GLConsts.py

Backout: https://hg.mozilla.org/integration/autoland/rev/cb9c458475b8baa9f950e7724128d68828c9938d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=42cdb2c4c76881fb2173e13aeb1bdd8dd08fbbc9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261482045&repo=autoland&lineNumber=302

[task 2019-08-14T00:36:35.472Z]
[task 2019-08-14T00:36:35.472Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:25:24 | at least two spaces before inline comment (E261)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:65:1 | expected 2 blank lines, found 1 (E302)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:79:1 | expected 2 blank lines, found 1 (E302)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:88:1 | expected 2 blank lines, found 1 (E302)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:138:1 | expected 2 blank lines after class or function definition, found 1 (E305)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:146:6 | SyntaxError: invalid syntax (E999)
[task 2019-08-14T00:39:56.094Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/gfx/gl/GLConsts.py:172:37 | at least two spaces before inline comment (E261)
[taskcluster 2019-08-14 00:39:56.456Z] === Task Finished ===

Flags: needinfo?(jgilbert)
See Also: → 1573737
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33f53e234a85
s/GLParseRegistryXML.py/GLConsts.py/ and port to python3+mypy. r=lsalzman
Blocks: py3
Flags: needinfo?(jgilbert)

https://hg.mozilla.org/mozilla-central/rev/42cdb2c4c768

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.