Open Bug 1573726 Opened 5 years ago Updated 2 years ago

maxBitrate not working for audio RTCRtpSender (opus)

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

Tracking Status
firefox68 --- affected
firefox69 --- affected
firefox70 --- affected

People

(Reporter: mmalavalli, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Steps to reproduce:

  1. Run https://jsfiddle.net/z45w2xLm/ in a new tab.
  2. Observe the iframe in which the JSFiddle is running.

Actual results:

The logged outgoing audio bitrate is constant irrespective of the value of "maxBitrate" set using RTCRtpSender.setParameters().

NOTE: This JSFiddle works on Chrome and Safari.

Expected results:

The logged outgoing audio bitrate should approximately match the value for "maxBitrate" set using RTCRtpSender.setParameters() (12000).

Summary: maxAudioBitrate not working for audio RTCRtpSender (opus) → maxBitrate not working for audio RTCRtpSender (opus)

I tested on Mac OS X 10.14 and Windows 10 with FF 68 release, FF Beta 69.0b14 and Nightly 70.0a1(2019-08-18) and I can reproduce the issue, in my case the value is around 72000.

Status: UNCONFIRMED → NEW
Component: Untriaged → WebRTC
Ever confirmed: true
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
Version: 68 Branch → Trunk

Hi, Andreas,
Is this something you are familiar with? Or do you know who is the best fit for this issue?
Thank you.

Flags: needinfo?(apehrson)

Byron, do we support maxBitrate for audio?

Flags: needinfo?(apehrson) → needinfo?(docfaraday)

I don't think so? It looks like most of that stuff only works if rid is being used, which only works on video. I suspect that this stuff will need to be fixed over in bug 1401592.

Flags: needinfo?(docfaraday)

FWIW maxBitrate and scaleResolutionDownBy definitely works without rid for video: https://jsfiddle.net/pehrsons/7L9k7zLq/

Passing over this in triage. :bwc, does the fiddle in comment 5 change what you said in comment 4? Should be mark this as related to bug 1401592 in some way -- dupe, is work we could break off from that bug, something else?

Flags: needinfo?(docfaraday)

I think this is still video-only.

Depends on: 1401592
Flags: needinfo?(docfaraday)

Marking P2 to match blocking bug.

Priority: -- → P2
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.