Closed Bug 1573781 Opened 5 months ago Closed 2 months ago

Clean up MozAutocompleteRichlistboxPopup fragment markup

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: dao, Assigned: thomas510111, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1567530 +++

Here:

https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/toolkit/content/widgets/autocomplete-popup.js#113

... we can replace ></richlistbox> with just />.

Attachment #9087841 - Attachment is obsolete: true

This is my first bug,so please notify me if i am doing something wrong.

(In reply to Thomas Kosmas from comment #11)

This is my first bug,so please notify me if i am doing something wrong.

Thomas, the patch itself looks good. Could you modify the commit message to include a summary as something like "Bug 1573781 - Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup"? I can review and land it after that.

Assignee: nobody → thomas510111
Status: NEW → ASSIGNED
Attachment #9106018 - Attachment description: Bug 1573781 → Bug 1573781 - Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6078cd6452f3
Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup r=bgrins
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.