1573781 - Clean up MozAutocompleteRichlistboxPopup fragment markup

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1567530 +++

Here:

https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/toolkit/content/widgets/autocomplete-popup.js#113

... we can replace ></richlistbox> with just />.

Comment 1

[Abdulrahman Alruwaishan]

Can I take care of this bug? I've built Firefox on my computer and am looking to start contributing with small fixes appropriate for beginners. I'll need help though!

Comment 2

[Dão Gottwald [:dao]]

(In reply to Abdulrahman Alruwaishan from comment #1)

Can I take care of this bug?

Sure!

I've built Firefox on my computer and am looking to start contributing with small fixes appropriate for beginners. I'll need help though!

Have you read https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide or some other instructions? Please let me know if you have specific questions.

Comment 3

[Abdulrahman Alruwaishan]

(In reply to Dão Gottwald [::dao] from comment #2)

Ok, so I've done some reading and here is my impression, if you can let me know whether it is accurate or not:

1. I pull using Mercurial to make sure the source on my computer is updated from mozilla-central
2. I make the edit
3. I commit the changes, indicating the bug number and other info like: "Bug 123456 - Change this thing to work better by doing something. r=reviewers" (and you would be the reviewer?)
4. Do something with Phabricator? Not exactly sure how that works but will read the info here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
5. Some kind of review process
6. Get code into tree.

How can I further clarify that? Thanks for your help!

Comment 4

[Dão Gottwald [:dao]]

I can be the reviewer, so you just add r=dao. The review will happen in Phabricator after you submitted the patch, so if you follow that user guide you should be all set. Landing the patch will happen through Lando, a tool that's also integrated with Phabricator.

Comment 5

[Abdulrahman Alruwaishan]

Attachment: abort: edit failed: emacs.exe exited with status 3

Ok, so I made sure everything was up to date with hg pull and hg up central, then made the edit, then built the browser again and made sure it worked, and then tried to commit. When I typed in 'hg commit', however, I got:

Comment 6

[Dão Gottwald [:dao]]

Does d:\compdev\mozilla-source\mozilla-central\ exist? Did you try to run hg commit in the same directory?

Comment 7

[Abdulrahman Alruwaishan]

I was trying to run the command in mozilla-source, not in mozilla-central! Thanks. Ok, now I've commited the change, and next I will be looking into the "Mozilla Phabricator User Guide" on the "How to submit a patch" page.

Comment 8

[Abdulrahman Alruwaishan]

I made a phabricator account, and I set up arcanist and phabricator on my computer, then linked my account with the install-certificate command. what do I do next? Should I use arcanist or moz-phab?

Comment 9

[Dão Gottwald [:dao]]

I'd recommend moz-phab.

Comment 10

[Thomas Kosmas]

Attachment: Bug 1573781 - Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup

Comment 11

[Thomas Kosmas]

This is my first bug,so please notify me if i am doing something wrong.

Comment 12

[Brian Grinstead [:bgrins]]

(In reply to Thomas Kosmas from comment #11)

This is my first bug,so please notify me if i am doing something wrong.

Thomas, the patch itself looks good. Could you modify the commit message to include a summary as something like "Bug 1573781 - Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup"? I can review and land it after that.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6078cd6452f3
Remove unnecessary closing tag for the richlistitem in MozAutocompleteRichlistboxPopup r=bgrins

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6078cd6452f3