Closed Bug 1573805 Opened 1 year ago Closed 3 months ago

Enable WS Monitor in all channels

Categories

(DevTools :: Netmonitor, task, P1)

task

Tracking

(firefox71 fixed, firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Let's enable WS monitor in all channels as soon as all M1 bugs are fixed.

Honza

Let's make sure this gets documented once implemented.

Sebastian

Keywords: dev-doc-needed

@Heng Yeow, can you please look at this, thanks!

Honza

Assignee: nobody → E0032242
Status: NEW → ASSIGNED
Assignee: E0032242 → odvarko

QA Manual Testing Summary green:
https://testrail.stage.mozaws.net/index.php?/reports/view/2089

All deps in QA meta (bug 1584184) solved

Plan: land in 72 (Nightly) and uplift to Beta 71.

Honza

Priority: P2 → P1
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/287aa26ecfbd
Enable WS Monitor in all channels r=Harald
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Comment on attachment 9107462 [details]
Bug 1573805 - Enable WS Monitor in all channels

Beta/Release Uplift Approval Request

  • User impact if declined: Developers not having support for inspecting WebSockets by default.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The feature went through Nightly testing period, it's been available in DevEdition for some time and it also went through QA.
  • String changes made/needed:
Attachment #9107462 - Flags: approval-mozilla-beta?

I am not seeing any card about enabling this feature in 71 in our Firefox Trello and we are nearing the end of the beta cycle, I would like Tania to shime in for QA before taking an uplift to beta.

Flags: needinfo?(tmaity)

Hi Pascal,
In trello I see following cards:
https://trello.com/c/hXb8yJWG/3618-network-websocket-monitor-gsoc
https://trello.com/c/cuqtUk84/805-network-websocket-monitor-gsoc

These two seem to be related with PI: https://jira.mozilla.com/browse/PI-289 from Fx71.
But, as I see the trello cards are for Fx 70.

Jan, can you take a look at the mentioned trello cards and see if they are related with PI-289?

Also, please note that testing for Preliminary Pre-Release for Websocket Inspector feature is in progress.

Flags: needinfo?(tmaity) → needinfo?(odvarko)

Harald, which one should we use?
Honza

Flags: needinfo?(odvarko) → needinfo?(hkirschner)

The cards are in different boards and updated to reflect version. I wasn’t aware that we need to have enabled cards for when features stay on DE for a release; I will clarify with Thomas on how we can track that better next time.

Flags: needinfo?(hkirschner)

Comment on attachment 9107462 [details]
Bug 1573805 - Enable WS Monitor in all channels

Feature got a green preliminary sign off in beta 71 by QA, uplift approved for 71 beta 11, thanks.

Attachment #9107462 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I've now documented this feature on MDN; see https://github.com/mdn/sprints/issues/2276#issuecomment-559523271 for the full details. Thanks to :Honza for the amazing hacks post, which I borrowed heavily from ;-)

Let me know if you'd like any more details added to the MDN page. Thanks!

You need to log in before you can comment on or make changes to this bug.