1573805 - Enable WS Monitor in all channels

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Let's enable WS monitor in all channels as soon as all M1 bugs are fixed.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Here is the corresponding piece of code:

https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/devtools/client/preferences/devtools-client.js#202-207

Honza

Comment 2

[Sebastian Zartner [:sebo]]

Let's make sure this gets documented once implemented.

Sebastian

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Heng Yeow, can you please look at this, thanks!

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1573805 - Enable WS Monitor in all channels

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

QA Manual Testing Summary green:
https://testrail.stage.mozaws.net/index.php?/reports/view/2089

All deps in QA meta (bug 1584184) solved

Plan: land in 72 (Nightly) and uplift to Beta 71.

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/287aa26ecfbd
Enable WS Monitor in all channels r=Harald

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/287aa26ecfbd

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9107462 [details]
Bug 1573805 - Enable WS Monitor in all channels

Beta/Release Uplift Approval Request

• User impact if declined: Developers not having support for inspecting WebSockets by default.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature went through Nightly testing period, it's been available in DevEdition for some time and it also went through QA.
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc (PTO until August 12)]

I am not seeing any card about enabling this feature in 71 in our Firefox Trello and we are nearing the end of the beta cycle, I would like Tania to shime in for QA before taking an uplift to beta.

Comment 10

[Brindusa Tot, Desktop QA]

Hi Pascal,
In trello I see following cards:
https://trello.com/c/hXb8yJWG/3618-network-websocket-monitor-gsoc
https://trello.com/c/cuqtUk84/805-network-websocket-monitor-gsoc

These two seem to be related with PI: https://jira.mozilla.com/browse/PI-289 from Fx71.
But, as I see the trello cards are for Fx 70.

Jan, can you take a look at the mentioned trello cards and see if they are related with PI-289?

Also, please note that testing for Preliminary Pre-Release for Websocket Inspector feature is in progress.

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Harald, which one should we use?
Honza

Comment 12

[:Harald Kirschner :digitarald]

The cards are in different boards and updated to reflect version. I wasn’t aware that we need to have enabled cards for when features stay on DE for a release; I will clarify with Thomas on how we can track that better next time.

Comment 13

[Pascal Chevrel:pascalc (PTO until August 12)]

Comment on attachment 9107462 [details]
Bug 1573805 - Enable WS Monitor in all channels

Feature got a green preliminary sign off in beta 71 by QA, uplift approved for 71 beta 11, thanks.

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/675029eeb048

Comment 15

[Chris Mills [:cmills]]

I've now documented this feature on MDN; see https://github.com/mdn/sprints/issues/2276#issuecomment-559523271 for the full details. Thanks to :Honza for the amazing hacks post, which I borrowed heavily from ;-)

Let me know if you'd like any more details added to the MDN page. Thanks!