1573833 - -Wparentheses on MoofParser.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

&' will be evaluated first [-Werror,-Wparentheses]
               ? decodeOffset.unwrap() + offsetOffset.unwrap()
               ^
 /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/media/mp4/MoofParser.cpp:524:15: note: place parentheses around the '&' expression to 
silence this warning
               ? decodeOffset.unwrap() + offsetOffset.unwrap()
               ^
  /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/media/mp4/MoofParser.cpp:524:15: note: place parentheses around the '?:' expression to
 evaluate it first
                ? decodeOffset.unwrap() + offsetOffset.unwrap()
                ^

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1573833 - Add missing & and parentheses r?jya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a550b308d88a
Add missing & and parentheses r=pehrsons

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a550b308d88a