Closed Bug 1573833 Opened 5 years ago Closed 5 years ago

-Wparentheses on MoofParser.cpp

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1573833 - Add missing & and parentheses r?jya
47 bytes, text/x-phabricator-request
Details | Review 
&' will be evaluated first [-Werror,-Wparentheses]
               ? decodeOffset.unwrap() + offsetOffset.unwrap()
               ^
 /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/media/mp4/MoofParser.cpp:524:15: note: place parentheses around the '&' expression to 
silence this warning
               ? decodeOffset.unwrap() + offsetOffset.unwrap()
               ^
  /home/sylvestre/dev/mozilla/mozilla-central.hg/dom/media/mp4/MoofParser.cpp:524:15: note: place parentheses around the '?:' expression to
 evaluate it first
                ? decodeOffset.unwrap() + offsetOffset.unwrap()
                ^
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #9085445 - Attachment description: Bug 1573833 - Add missing parentheses to silent a clang warning r?jya → Bug 1573833 - Add missing & and parentheses r?jya
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a550b308d88a
Add missing & and parentheses r=pehrsons

https://hg.mozilla.org/mozilla-central/rev/a550b308d88a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: