1573841 - Update HarfBuzz to 2.6.0

Status: RESOLVED FIXED

(Core :: Graphics: Text, task, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

Overview of changes leading to 2.6.0
Tuesday, August 13, 2019

• New OpenType metrics, baseline, and metadata table access APIs.
• New API to set font variations to a named-instance.
• New hb-gdi.h header and API for creating hb_face_t from HFONT.
• Amalgam: Provide a single-file harfbuzz.cc file for easier alternate building.
• More size-reduction configurable options, enabled by HB_TINY.
• New API:
  +hb_font_set_var_named_instance()
  +hb_gdi_face_create()
  +hb_ot_layout_baseline_tag_t
  +hb_ot_layout_get_baseline()
  +hb_ot_meta_tag_t
  +hb_ot_meta_get_entry_tags()
  +hb_ot_meta_reference_entry()
  +hb_ot_metrics_tag_t
  +hb_ot_metrics_get_position()
  +hb_ot_metrics_get_variation()
  +hb_ot_metrics_get_x_variation()
  +hb_ot_metrics_get_y_variation()

Comment 1

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)

• Amalgam: Provide a single-file harfbuzz.cc file for easier alternate building.

Well, this could certainly make for a smaller moz.build. Any thoughts on me trying this out, Jonathan?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

That said, it'd bring in some things we've left out in the past, like hb-coretext, hb-directwrite, etc.

Comment 3

[Jonathan Kew [:jfkthame]]

Yeah, given that we are deliberately selective about what we include in our build, I'd be inclined to ignore that for now.

(It does suggest, though, that we might be able to move the files we currently have in SOURCES back to UNIFIED_SOURCES, as the conflicts we originally encountered may have been resolved.)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1573841 - Update HarfBuzz to 2.6.0. r=jfkthame

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Jonathan Kew (:jfkthame) from comment #3)

(It does suggest, though, that we might be able to move the files we currently have in SOURCES back to UNIFIED_SOURCES, as the conflicts we originally encountered may have been resolved.)

Indeed we can :). Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c62f2a5818e6a5acfc5b10e766af5ab9867af022

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2da42c3a66d
Update HarfBuzz to 2.6.0. r=jfkthame

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b2da42c3a66d

Comment 8

[Behdad Esfahbod]

First, please use 2.6.1. 2.6.0 had a regression.

Second, all conflicts are fixed. Also, hb-coretext, etc won't compile anything if the corresponding HAVE_CORETEXT etc are not defined. So it's safe to just include harfbuzz.cc But you can do your own unified build as well.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Behdad Esfahbod from comment #8)

First, please use 2.6.1. 2.6.0 had a regression.

We updated to 2.6.1 in bug 1576041 prior to Fx70 going to Beta, so we won't be shipping anything with 2.6.0.