1573859 - The DOM Mutation side panel could show help if empty

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The empty DOM Mutation side panel currently shows only: No breakpoints to display.

It could show a little help like:

• "Use Inspector panel context menu to create a DOM breakpoint"
• Or perhaps link to the Inspector panel
• And perhaps link to MDN

Whatever would help the user to start using this feature.

Honza

Comment 1

[:Harald Kirschner :digitarald]

+1 on summarizing the add-dom-bp flow and linking to Inspector to get the user started.

Comment 2

[David Walsh :davidwalsh]

Good idea; do we have a precedent for this UX-wise? A button would be good but we can also do this as text. I also think it may be best to open a link on MDN to the page that shows people how to get to the context menu. Or we just put 2-3 sentences that describe it.

Comment 3

[:Harald Kirschner :digitarald]

Probably a mix of:

• Application panel (devtools.application.enabled)
• Network panel
• Accessibility Inspector
• Flexbox and Grid panels in Inspector somewhat.

Comment 4

[:Harald Kirschner :digitarald]

Taking a shot at word-smithing:

*"DOM Breakpoints let you pause code that changes a DOM node or its children. Lean more.

To get started, right-click a node in Inspector and select Break on ….".*

Comment 5

[David Walsh :davidwalsh]

Attachment: Bug 1573859 - Allow users to get to inspector from Dom Mutation Breakpoints panel r=jlast

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05f1cba504d0
Allow users to get to inspector from Dom Mutation Breakpoints panel r=jlast

Comment 7

[Razvan Maries]

Backed out for perma fails on browser_misused_characters_in_strings.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=264761320&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=os%2Cx%2C10.14%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1014-64-shippable%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&revision=05f1cba504d037883794c7fed1e86e3b8cef3140

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264761320&repo=autoland&lineNumber=2109

[task 2019-09-03T16:15:50.922Z] 16:15:50 INFO - TEST-START | browser/base/content/test/static/browser_misused_characters_in_strings.js
[task 2019-09-03T16:15:51.495Z] 16:15:51 INFO - TEST-INFO | started process screencapture
[task 2019-09-03T16:15:51.677Z] 16:15:51 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-03T16:15:51.677Z] 16:15:51 INFO - Buffered messages logged at 16:15:50
[task 2019-09-03T16:15:51.677Z] 16:15:51 INFO - Entering test bound checkAllTheProperties
[task 2019-09-03T16:15:51.677Z] 16:15:51 INFO - Buffered messages logged at 16:15:51
[task 2019-09-03T16:15:51.677Z] 16:15:51 INFO - TEST-PASS | browser/base/content/test/static/browser_misused_characters_in_strings.js | Found 147 .properties files to scan for misused characters -
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - Buffered messages finished
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_misused_characters_in_strings.js | jar:file:///Users/cltbld/tasks/task_1567527048/build/application/Firefox%20Nightly.app/Contents/Resources/browser/omni.ja!/chrome/en-US/locale/en-US/devtools/client/debugger.properties with key=noDomMutationBreakpoints has a misused double-quote. Double-quoted strings should use Unicode “foo” instead of "foo". -
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - Stack trace:
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_misused_characters_in_strings.js:testForError:145
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_misused_characters_in_strings.js:testForErrors:174
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_misused_characters_in_strings.js:checkAllTheProperties:222
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1350
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1385
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1213
[task 2019-09-03T16:15:51.678Z] 16:15:51 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-09-03T16:15:51.679Z] 16:15:51 INFO - Leaving test bound checkAllTheProperties
[task 2019-09-03T16:15:51.679Z] 16:15:51 INFO - Entering test bound checkAllTheDTDs
[task 2019-09-03T16:15:51.766Z] 16:15:51 INFO - TEST-PASS | browser/base/content/test/static/browser_misused_characters_in_strings.js | Found 54 .dtd files to scan for misused characters -
[task 2019-09-03T16:15:51.815Z] 16:15:51 INFO - Leaving test bound checkAllTheDTDs
[task 2019-09-03T16:15:51.815Z] 16:15:51 INFO - Entering test bound checkAllTheFluents
[task 2019-09-03T16:15:52.606Z] 16:15:52 INFO - Leaving test bound checkAllTheFluents
[task 2019-09-03T16:15:52.606Z] 16:15:52 INFO - Entering test bound ensureWhiteListIsEmpty
[task 2019-09-03T16:15:52.606Z] 16:15:52 INFO - TEST-PASS | browser/base/content/test/static/browser_misused_characters_in_strings.js | No remaining whitelist entries exist -
[task 2019-09-03T16:15:52.606Z] 16:15:52 INFO - Leaving test bound ensureWhiteListIsEmpty
[task 2019-09-03T16:15:52.607Z] 16:15:52 INFO - GECKO(1748) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 112: uncaught exception: Object
[task 2019-09-03T16:15:52.607Z] 16:15:52 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 112}]
[task 2019-09-03T16:15:52.607Z] 16:15:52 INFO - GECKO(1748) | MEMORY STAT | vsize 8327MB | residentFast 1054MB | heapAllocated 806MB
[task 2019-09-03T16:15:52.607Z] 16:15:52 INFO - TEST-OK | browser/base/content/test/static/browser_misused_characters_in_strings.js | took 1696ms
[task 2019-09-03T16:15:52.641Z] 16:15:52 INFO - checking window state

Backout: https://hg.mozilla.org/integration/autoland/rev/2c8e47036b7416d7f3db9df702f11d3dfc181814

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90908044afc6
Allow users to get to inspector from Dom Mutation Breakpoints panel r=jlast,flod

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/90908044afc6