1573884 - Include Java stack with native crashes for assertion failures and MOZ_CRASH

Status: NEW

(GeckoView :: General, enhancement, P3)

Description

[Randall Barker [:rbarker]]

Currently in GeckoView, a native crash report only includes the native stack. However sometimes it would be beneficial to know the Java stack that was responsible for calling the native code. If the Java stack for the crashing thread were included in the crash report, it would probably help in diagnosing and fixing some issues.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

For an actual native crash, we can't do this, because it's not safe to touch the VM. For assertions or other abort-like cases, though, we should be able to do this.

Comment 2

[Chris Peterson [:cpeterson]]

We need to change the assertion macro to capture the Java stack. The Java stack may include PII, so we need to ensure that the Java stack is private on crash-stats.

Comment 3

[Jan Henning [:JanH]]

The Java stack may include PII, so we need to ensure that the Java stack is private on crash-stats.

Is it actually necessary to hide the complete stack trace? For Fennec crashes, AFAIK only the full exception message is hidden because that can indeed possibly contain some PII like file paths, other (user-entered) strings, etc.

Comment 4

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.