Closed Bug 1573886 Opened 2 months ago Closed 2 months ago

backdrop-filter blur can have artifacts due to scaling

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: cbrewster, Assigned: cbrewster)

Details

Attachments

(2 files)

WebRender does blurring via multiple passes, first it scales the source down using scale tasks and then does a horizontal and vertical blur pass. To ensure that errors are not introduced due to scaling, the width and height of the source must be multiples of two.
https://searchfox.org/mozilla-central/rev/c7e8bc4996f979e5876b33afae3de3b1ab4f3ae1/gfx/wr/webrender/src/render_task.rs#1031

When blurring for backdrop-filter, we do not adjust the size so it is a multiple of two because this can add extra padding of transparent pixels to the source. This results in incorrect blur results.

We should do size adjustment but also track the original size so we don't include the extra transparent padding while computing the blur.

Priority: -- → P3
Keywords: checkin-needed

Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26094588b48e
Fix backdrop-filter blur errors due to incorrect scaling r=kvark

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → cbrewster
You need to log in before you can comment on or make changes to this bug.