Closed Bug 1573902 Opened 5 years ago Closed 5 years ago

PChromiumCDM::Init's return value should be named to reflect that it is used

Categories

(Core :: Audio/Video: GMP, defect, P3)

Product:
Core
Component:
Audio/Video: GMP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: bryce, Assigned: bryce)

Details

Attachments

(1 file)

Bug 1573902 - Fix CDM Init return value name in IPDL. r?dminor!
47 bytes, text/x-phabricator-request
Details | Review

PChromiumCDM:Init states that the return value is unused, but this is not the case, as shown here. The IPDL should be updated to reflect this and avoid confusion.

Summary: PChromiumCDM::Init should have a better return value name → PChromiumCDM::Init's return value should be named to reflect that it is used

The return value for PChromiumCDM::Init was unused when the IPDL change was
first made. However, that quickly changes, but I failed to update the IPDL to
reflect that the value is now used to propagate the value that CDM interface 10
Widevine modules give us via the OnInitialized callback.

This patch fixes the IPDL to reflect that. The changes in C++ code have already
been made, so no change needed there.

Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c287afc3556
Fix CDM Init return value name in IPDL. r=dminor

https://hg.mozilla.org/mozilla-central/rev/7c287afc3556

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: