1573907 - list item with value attribute in <ol reversed> causes the list to start too high (by one per item with value)

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Any list item with a value attribute causes an <ol reversed> to start one higher than it should. Chrome behaves correctly.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simple testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: slightly more complex testcase

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I think this line should be removed and that should fix it, but I haven't checked yet since I ran out of time for the day: https://searchfox.org/mozilla-central/rev/3366c3d24f1c3818df37ec0818833bf085e41a53/layout/base/nsCounterManager.cpp#180

Comment 4

[Emilio Cobos Álvarez [:emilio]]

(actually I have a couple more minutes)

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1573907 - Fix interaction of <li value> inside <ol reversed>. r=mats

The counting code was incrementing the start counter twice for <li value>, as it
generates both an increment and a reset.

We should instead only increment it once per list-item, that is, once per
increment.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1573907 - Make non-list-items not increment the start value for <ol reversed>. r=mats

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9bdb526a7a0
Fix interaction of <li value> inside <ol reversed>. r=mats

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bc9d6bfeb5a
Make non-list-items not increment the start value for <ol reversed>. r=mats

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18451 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a9bdb526a7a0
https://hg.mozilla.org/mozilla-central/rev/0bc9d6bfeb5a