15740 - ReadWriteProc needs to check return value from PB[Read|Write]Async

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Simon Fraser [no longer active]]

ReadWriteProc makes calls to PBReadAsync and PBWriteAsync, but throws away
the return values:

	(void) PBReadAsync(&pbAsync.pb);
and
	(void) PBWriteAsync(&pbAsync.pb);

This is bad, because if these routines fail right away (e.g. attempt to write
to locked file), then we'll go off into threading land and never return.
We have to check those return values.

Comment 1

[Steve Dagley]

Will fix this one once the 3.5 branch lands (expected in the next week or so)

Comment 2

[Steve Dagley]

Fix checked in.  Since this is a case of fixing a potential problem without an
example of the potential problem biting us yet I don't know of a way for QA to
verify this.  "Trust me" said the man with the glowing eyes.