1574223 - Consider treating document level ontouchmove as passive

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Ksenia Berezina [:ksenia]]

Attachment: 35163.html

On this page https://www.corsair.com/us/en/Categories/Products/Cases/Mid-Tower-ATX-Cases/Obsidian-Series%E2%84%A2-550D-Mid-Tower-Quiet-Case/p/CC-9011015-WW

the site is using:

      document.ontouchmove = function (e) {
        e.preventDefault();
      }

which breaks scrolling in Firefox on Android. Looks like Chrome threats ontouchmove here as passive, so preventDefault doesn't work.

Should we consider doing that as well?

(looks like it was implemented for touchstart and touchmove here https://bugzilla.mozilla.org/show_bug.cgi?id=1449268)

Attached a reduced test case as well

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

touchmove should be considered passive by default.
https://searchfox.org/mozilla-central/source/dom/events/EventListenerManager.cpp#662-663,667-668

Hmm, I wonder if APZ is doing something unexpected here.

And on Windows with touchscreen panning works just fine.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

ah, I think I see where the issue is.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a09a922dd3e92136386611eb19a5d9252d60b332

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1574223, make touchstart/move passive by default also when using event handlers, not only event listeners, r=masayuki

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5549942df83
make touchstart/move passive by default also when using event handlers, not only event listeners, r=masayuki

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e5549942df83

Comment 7

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.dev/en-CA/docs/2019/ontouchstart-ontouchmove-event-handlers-are-now-passive-by-default/