Closed Bug 1574269 Opened 2 years ago Closed 2 years ago

Further improve documentation on porting front-end code to JSWindowActors

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mconley, Assigned: ablayelyfondou)

Details

Attachments

(1 file)

Bug 1574269 - Improve in-tree documentation for fission. r?mconley
47 bytes, text/x-phabricator-request
Details | Review

A few things:

  1. Be more consistent between "JS Window Actor" and "JSWindowActor"
  2. Mention that in the constructor of a JSWindowActor, the messaging infrastructure hasn't been set up yet, and the manager / BrowsingContext don't exist yet.
  3. Add a big ol' warning about RDM and how fragile it is.

mconley: do you want me to work on this?

Flags: needinfo?(mconley)

If you have a few moments, yes, that'd be lovely! Thanks!

Flags: needinfo?(mconley)
Assignee: nobody → ablayelyfondou
Attachment #9087466 - Attachment description: Bug 1574269 - Improve in-tree documentation for fission. → Bug 1574269 - Improve in-tree documentation for fission. r?mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71c26f3712c6
Improve in-tree documentation for fission. r=mconley

https://hg.mozilla.org/mozilla-central/rev/71c26f3712c6

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.