1574366 - Watch Expressions: Rep Target overlaps close button

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[David Walsh :davidwalsh]

Attachment: HoverTargetOverlap.png

When hovering over a watch expression that is an element rep (ex: document.body), the inspector icon and close button overlap.

Comment 1

[Chris Muldoon]

Hi, could i give this one a go?

First attempt at a bug, so any mentoring would be greatly appreciated.

Comment 2

[David Walsh :davidwalsh]

Yes, of course Chris! Please let me know if I can help! :)

Comment 3

[Chris Muldoon]

Cool thanks.

Confirming steps to reproduce:

1. Go to a website, i.e. http://todomvc.com/examples/jquery/#/all
2. Open the debugger
3. In the debugger, add a watch expression i.e. "document.body"
4. Hovering over our newly created watch expression, a close button appears. If the syntax is too long, or we have made the side tab smaller (where our watch expression tab is located), the inspector icon and close button element overlap.

Comment 4

[Chris Muldoon]

Attachment: Bug 1574366 - Remove flexbox from .node.object.node for better formatting. r=davidwalsh

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c192db6ab723
Remove flexbox from .node.object.node for better formatting. r=davidwalsh

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c192db6ab723

Comment 7

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0a1(15.08.2019).
Fix verified with 70.0b7 on WIndows 10, macOS 10.13, Ubuntu 16.04.