Closed Bug 1574417 Opened 7 years ago Closed 5 years ago

Perma [tier2][fission] | TEST-UNEXPECTED-FAIL | damp | netmonitor/complicated.js: Test timed out

Categories

(DevTools :: Netmonitor, defect, P5)

defect

Tracking

(firefox-esr78 wontfix, firefox83 wontfix, firefox84 wontfix, firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jdescottes)

References

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(1 file, 2 obsolete files)

Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=261937082&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/RAs6gUdlRpCLM6eNYGDDBw/runs/0/artifacts/public/logs/live_backing.log


[task 2019-08-16T05:00:53.183Z] 05:00:53 INFO - PID 1236 | Close toolbox on 'complicated.jsdebugger'
[task 2019-08-16T05:00:53.257Z] 05:00:53 INFO - PID 1236 | Garbage collect
[task 2019-08-16T05:00:54.466Z] 05:00:54 INFO - PID 1236 | debugger/complicated.js took 6250ms.
[task 2019-08-16T05:00:54.466Z] 05:00:54 INFO - PID 1236 | Loading test 'styleeditor/complicated.js'
[task 2019-08-16T05:00:54.466Z] 05:00:54 INFO - PID 1236 | Executing test 'styleeditor/complicated.js'
[task 2019-08-16T05:00:54.466Z] 05:00:54 INFO - PID 1236 | [Parent 3588, Gecko_IOThread] WARNING: pipe error: 109: file z:/task_1565922974/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-08-16T05:00:54.484Z] 05:00:54 INFO - PID 1236 | [Child 2844, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1565922974/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-08-16T05:00:55.720Z] 05:00:55 INFO - PID 1236 | 'complicated.styleeditor.open.settle.DAMP' took 0.12014939484652132ms.
[task 2019-08-16T05:00:55.720Z] 05:00:55 INFO - PID 1236 | Garbage collect
[task 2019-08-16T05:00:56.974Z] 05:00:56 INFO - PID 1236 | Reload page on 'complicated.styleeditor'
[task 2019-08-16T05:00:58.474Z] 05:00:58 INFO - PID 1236 | Wait for pending paints on 'complicated.styleeditor'
[task 2019-08-16T05:00:58.474Z] 05:00:58 INFO - PID 1236 | 'complicated.styleeditor.reload.settle.DAMP' took 0.20514143840409815ms.
[task 2019-08-16T05:00:58.474Z] 05:00:58 INFO - PID 1236 | Close toolbox on 'complicated.styleeditor'
[task 2019-08-16T05:00:58.514Z] 05:00:58 INFO - PID 1236 | Garbage collect
[task 2019-08-16T05:00:59.792Z] 05:00:59 INFO - PID 1236 | styleeditor/complicated.js took 5325ms.
[task 2019-08-16T05:00:59.792Z] 05:00:59 INFO - PID 1236 | Loading test 'netmonitor/complicated.js'
[task 2019-08-16T05:00:59.792Z] 05:00:59 INFO - PID 1236 | Executing test 'netmonitor/complicated.js'
[task 2019-08-16T05:00:59.792Z] 05:00:59 INFO - PID 1236 | [Parent 3588, Gecko_IOThread] WARNING: pipe error: 109: file z:/task_1565922974/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-08-16T05:00:59.812Z] 05:00:59 INFO - PID 1236 | [Child 4020, Chrome_ChildThread] WARNING: pipe error: 109: file z:/task_1565922974/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-08-16T05:05:59.818Z] 05:05:59 INFO - PID 1236 | TEST-UNEXPECTED-FAIL | damp | netmonitor/complicated.js: Test timed out
[task 2019-08-16T05:05:59.836Z] 05:05:59 INFO - Terminating psutil.Process(pid=1236L, name='firefox.exe', started='04:53:49')
[task 2019-08-16T05:06:07.473Z] 05:06:07 INFO - rmtree() failed for "('c:\users\task_1565917244\appdata\local\temp\tmpzedkgw',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2019-08-16T05:06:07.473Z] 05:06:07 INFO - rmtree() failed for "('c:\users\task_1565917244\appdata\local\temp\tmpzedkgw',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2019-08-16T05:06:07.473Z] 05:06:07 INFO - rmtree() failed for "('c:\users\task_1565917244\appdata\local\temp\tmpzedkgw',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2019-08-16T05:06:07.473Z] 05:06:07 INFO - rmtree() failed for "('c:\users\task_1565917244\appdata\local\temp\tmpzedkgw',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2019-08-16T05:06:07.473Z] 05:06:07 INFO - rmtree() failed for "('c:\users\task_1565917244\appdata\local\temp\tmpzedkgw',)". Reason: The process cannot access the file because it is being used by another process (13). Retrying...
[task 2019-08-16T05:06:07.473Z] 05:06:07 INFO - Exception while removing profile directory: c:\users\task_1565917244\appdata\local\temp\tmpzedkgw
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - [Error 32] The process cannot access the file because it is being used by another process: 'c:\users\task_1565917244\appdata\local\temp\tmpzedkgw\profile\cert9.db'
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - TEST-UNEXPECTED-ERROR | damp | unexpected error
[task 2019-08-16T05:06:07.474Z] 05:06:07 ERROR - Traceback (most recent call last):
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - File "C:\Users\task_1565917244\build\tests\talos\talos\run_tests.py", line 276, in run_tests
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - talos_results.add(mytest.runTest(browser_config, test))
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - File "C:\Users\task_1565917244\build\tests\talos\talos\ttest.py", line 64, in runTest
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - return self._runTest(browser_config, test_config, setup)
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - File "C:\Users\task_1565917244\build\tests\talos\talos\ttest.py", line 216, in _runTest
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - debugger_args=browser_config['debugger_args']
[task 2019-08-16T05:06:07.474Z] 05:06:07 INFO - File "C:\Users\task_1565917244\build\tests\talos\talos\talos_process.py", line 156, in run_browser
[task 2019-08-16T05:06:07.475Z] 05:06:07 INFO - raise TalosError("unexpected error")
[task 2019-08-16T05:06:07.475Z] 05:06:07 INFO - TalosError: unexpected error

Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

(In reply to Noemi Erli[:noemi_erli] from comment #6)

Continued with the investigation and reached to: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cshippable%2Copt%2Ctalos%2Cperformance%2Ctests%2Ctest-macosx1014-64-shippable%2Fopt-talos-damp-e10s%2Ct%28damp%29&tochange=56af0aa5f1169b1b5ba7ab6fe5a7d652285720d4&fromchange=af990b74d334f3146888f4d2aa21a74017e6543d&selectedTaskRun=JBfrAPzWRti7ToDBRBYUBQ.0
Bas Schouten, could this be triggered somehow by the landing of Bug 1606706?

That patch changed 'timings' in general, in subtle ways, it won't affect this directly, but it definitely can make some intermittents become rarer and some intermittents become more common. If a test has timing issues, it may affect when and how often those issues occur.

Flags: needinfo?(bas)
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Component: Talos → Netmonitor
Product: Testing → DevTools
Version: Version 3 → unspecified
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Summary: Intermittent PID 1236 | TEST-UNEXPECTED-FAIL | damp | netmonitor/complicated.js: Test timed out → Perma [tier2][fission] | TEST-UNEXPECTED-FAIL | damp | netmonitor/complicated.js: Test timed out

Interesting to see that netmonitor/complicated.js is now a permafail on Fission platforms. I suspect that something landed after my try pushes for Bug 1677587 (no failure on fission at https://treeherder.mozilla.org/jobs?repo=try&revision=ec00fbb804088a67a8e429604c0606a3920df4c9&selectedTaskRun=a1anu85mQo6DRc6fdLb_6g.0) that make the test fail.

We can disable it on fission, but it would be nice to first understand what made this permafail.

We seem to be missing 2 GET requests when Fission is enabled. I compared the HAR export before and after the regression, and the 2 missing requests were:

They are referenced in css files which are found in both HAR exports:
http://www.facebook.com-talos/fis/tp5n/bild.de/static.ak.fbcdn.net/rsrc.php/v1/yT/r/0wnSWdIMunu.css
http://www.facebook.com-talos/fis/tp5n/bild.de/static.ak.fbcdn.net/rsrc.php/v1/yZ/r/iWHQrTjA1HD.css

Either we are no longer requesting the images, or the netmonitor is not capturing the requests. Bisecting didn't really help so far.
We could temporarily lower the expected number of requests by 2 when Fission is enabled. This would be better than skipping the test.

Assignee: nobody → jdescottes
Attachment #9188858 - Attachment is obsolete: true

I got confused by the difference with the requests number, but the root cause of the timeout is that our helper awaitBrowserLoaded https://searchfox.org/mozilla-central/rev/1d34bd022de0b55c81d9db6026f69bda1d4a86d2/testing/talos/talos/tests/devtools/addon/content/damp.js#54 never resolves when Fission is enabled.

It's a very old-style helper, using framescript and message manager. It should be converted to use JS Window Actors (doing a prototype right now). But it feels like the top level page never actually finishes loading for complicated tests when Fission is enabled. I will check if I get the same issue with actors, and if I do it means there is a bigger issue here.

Other "complicated" tests use a custom way to check the "reload" of the page and don't rely on this helper.

Using JSWindowActors doesn't help, the page still never finishes loading. Something in the following pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0463e97f6980f55f1016009263052e86c5513802&tochange=89a7ce645009272cd0a3e3765cb2fa5312f34a25

Since I wrote a prototype to remove the framescript, I'll push that on https://bugzilla.mozilla.org/show_bug.cgi?id=1678379

Blocks: 1678565
Attachment #9188988 - Attachment is obsolete: true
See Also: → 1678741
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66f906af343d [devtools] Disable netmonitor/compicated DAMP test on Fission platform r=bomsy,perftest-reviewers
Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

It looks like this test times out because of some other reason now.
I've not been able to understand why, but I see the test timeout on this line:
https://searchfox.org/mozilla-central/rev/625c3d0c8ae46502aed83f33bd530cb93e926e9f/testing/talos/talos/tests/devtools/addon/content/tests/netmonitor/netmonitor-helpers.js#199

  const waitForEditor = waitForDOMElement(
    monitor,
    "#response-panel .CodeMirror.cm-s-mozilla",
    win
  );
  mouseDownElement(request, win);
  await waitForEditor; // <=== here

I suspect that we end up selecting a request that has no response content available.
The code before that ensures selecting the biggest request, but it might be subject to various race conditions as it is quite asynchronous and not so simple.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: