1574498 - The “Login List” is not scrolled to the top after sorting the logins

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: LoginList_sort.mp4

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-16) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• The Firefox browser is opened.
• The "about:logins" page is opened.
• Have multiple saved logins.

[Steps to reproduce]:

1. Scroll down the “Login List”.
2. Click on the “Sort by: Name (A-Z)” dropdown menu.
3. Select the “Last Used”/”Last Modified” option.
4. Observe the behavior of the list.

[Expected result]:

• The “Login List” is rearranged and is scrolled to the top.

[Actual result]:

• The “Login List” is not scrolled to the top.

[Additional notes]:

• Attached a screen recording with the issue.

Comment 1

[Tim Nguyen :ntim]

Hi Ryan, where should the list scroll (if it should be) after getting sorted ?

Comment 2

[rgaddis]

I think it should function as Simona has described, and jump to the top of the login list, as long as we maintain the login you have selected as active regardless of changing the sort order.

For example... if I have my logins sorted alphabetically, and the first entry for Amazon is selected, once I change to sorting by recency, Amazon should still be selected in the main entry details area, though the Amazon list card may now be hidden (if it moves to the bottom of my login list due to not being recently used).

Comment 3

[Matthew N. [:MattN]]

It seems like Finder on macOS and Explorer on Windows keep the selected item scrolled into view after sorting, rather than scrolling to the top. Did you consider this as an option? It seems more natural to me.

Comment 4

[rgaddis]

Fair point. I had (perhaps incorrectly) assumed that it would be more work to track and maintain visible presence of the item in the last, relative to the sort order changing, but also, and perhaps more importantly, that most folks will probably wish to change the sort order at the start of their experience, upon opening the management tab...

Since the first item is already selected by default, my concern was that the first item would 'drive' them to wherever it lands in the new sort order, rather than having the sort order appropriately prioritizing what is visible at the top of the list. Therefore, it felt to me like sort order should be a priority over active state visibility...

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1574498 - Scroll the login-list to the top after changing the sort order. r?MattN

This patch does not attempt to keep the selected login visible, as we select a login upon loading so the user may not care where their currently selected login resides within the sort order.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/708c110cf4ea
Scroll the login-list to the top after changing the sort order. r=MattN

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/708c110cf4ea

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9093675 [details]
Bug 1574498 - Scroll the login-list to the top after changing the sort order. r?MattN

Polish issue for Skyline feature, part of batch uplift for beta 9.

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e994bd8f2e5

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190923094800) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04 x64.

• The “Login List” is scrolled to the top after sorting the logins.

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04 x64.

• The “Login List” is scrolled to the top after sorting the logins.