1574526 - "Attach File" is an unstyled link rather than a button

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Botond Ballo [:botond]]

Attachment: Screenshot

STR

1. Log into BMO and visit any bug.
2. Scroll down to below the attachments table and observe the "Attach File" command.

Expected results

It's a button of some sort.

Actual results

It's a plain un-styled link. Even its positioning is strange (see attached screenshot). It kind of looks out of place in the UI.

Comment 1

[Kohei Yoshino [:kohei]]

I’ve fixed this in Bug 1344091 that will be deployed probably next week :-)

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: screenshot of new UI

Comment 3

[:glob ✱]

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #1)

I’ve fixed this in Bug 1344091 that will be deployed probably next week :-)

That screenshot looks good, please make sure you don't regress bug 1257608:

The normal bugzilla UI uses a link to attach files, so you can ctrl-click it to open in new tab. The experimental interface uses a button, forcing it to clobber your tab.

Comment 4

[:glob ✱]

(In reply to Byron Jones ‹:glob› 🎈 from comment #3)

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #1)

I’ve fixed this in Bug 1344091 that will be deployed probably next week :-)

That screenshot looks good, please make sure you don't regress bug 1257608:

Looking at the PR it does appear to regress bug 1257608; left a comment there too.

Comment 5

[Kohei Yoshino [:kohei]]

Thanks :glob for the heads-up! I’ll fix that now.

Comment 6

[Kohei Yoshino [:kohei]]

Fixed in Bug 1344091.