1574567 - Frequent "Assertion failure: parentFound" with Fission enabled

Status: RESOLVED WORKSFORME

(Core :: DOM: Service Workers, task, P2)

Description

[Andrew McCreight [:mccr8]]

There are 11 tests that are annotated that they crash with Fission with some service worker manager service related crash, but they don't actually crash, so we should enable them. I think there was one other service worker related test that I noticed passes with Fission.

Comment 1

[Andrew McCreight [:mccr8]]

browser_antitracking_subiframes.js is the test that passes now.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1574567 - Enable various tests for Fission that don't actually crash with ServiceWorkerManagerService signatures.

browser_antitracking_subiframes.js also seems to pass.

Comment 3

[Andrew McCreight [:mccr8]]

And browser_permissions_event_telemetry.js.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bd128c84b4e
Enable various tests for Fission that don't actually crash with ServiceWorkerManagerService signatures. r=kmag

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2bd128c84b4e

Comment 6

[Alexandru Michis [:malexandru]]

Andrew, since your changes landed on central, the bc5 jobs failure rate has increased considerably: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-fis-e10s-5%2Cm-fis%28bc5%29&fromchange=8a9e9189cd98350f27c9f36bddca67ff03082339&group_state=expanded&tochange=ce8742e6c77b7aef8a2beba32776ca3494adacb8

Could you please take a look at it?

Comment 7

[Razvan Maries]

Andrew, since 2bd128c84b4e was landed, the Linux tier 2 Mochitest bc2 jobs became perma: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-fis-e10s-2%2Cm-fis%28bc2%29&tochange=ce8742e6c77b7aef8a2beba32776ca3494adacb8&fromchange=7c1def596e462a4a96cd5e187e4e40911f7c3f02&selectedJob=262261504

Could you take a look?

Comment 8

[Andrew McCreight [:mccr8]]

Somehow I failed to realize my try run only included Mochitest plain, which explains how I didn't notice this on my try run...

This is pretty bizarre, though. None of the test directories that my patch touches seem to be running in bc2.

The crash seems to happen in shutdown after tests in browser/base/content/test/trackingUI/ run. Maybe bc tests aren't run-by-directory and my patch caused bucketing to shift somehow? Is this kind of weirdness familiar to you, Kris?

Comment 9

[Andrew McCreight [:mccr8]]

Ok, so there's just the intermittent leak from comment 6 to address. That looks service worker related, so it makes more sense. I'll see if I can reproduce that today.

Comment 10

[Andrew McCreight [:mccr8]]

On second look, it seems like there are a number of crash that match what Kris filed.

They are actually assertion failures:
Assertion failure: parentFound, at /builds/worker/workspace/build/src/dom/serviceworkers/ServiceWorkerManagerService.cpp:188

Please back this patch out.

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6a6b91c035e
Backed out changeset 2bd128c84b4e for causing assertion failures on ServiceWorkerManagerService.cpp.

Comment 12

[Andrew McCreight [:mccr8]]

I looked through the failures in comment 6, and they break down like this:

• Assertion failure: parentFound, at /builds/worker/workspace/build/src/dom/serviceworkers/ServiceWorkerManagerService.cpp:188
  4 browser/base/content/test/permissions/browser_permissions.js
  1 browser/base/content/test/permissions/browser_temporary_permissions_expiry.js
  1 browser/base/content/test/permissions/browser_temporary_permissions_navigation.js

• browser/base/content/test/permissions/browser_autoplay_blocked.js | Test timed out

• leakcheck | tab 488 bytes leaked (ServiceWorkerJob, ServiceWorkerJobQueue, ServiceWorkerJobQueue::Callback, nsAuthURLParser, [...]
  browser/base/content/test/sanitize/browser_sanitize-offlineData.js

• leakcheck | tab 7852 bytes leaked (ChannelEventQueue, CondVar, ConsoleReportCollector, CookieSettings, HttpChannelChild, ...)
  2 browser/base/content/test/permissions/browser_temporary_permissions_expiry.js
  browser/base/content/test/permissions/browser_permissions.js

I also looked at a few other M-fis() bc runs, and saw "Assertion failure: parentFound" in the other tests I disabled.

From the browser.ini annotation, browser_devtools_serviceworker_interception.js also seems to hit this assertion.

This assertion failure also seems to happen on trunk, but much less frequently, as seen in in bug 1522243.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/a6a6b91c035e

Comment 14

[Andrew McCreight [:mccr8]]

Andrew, it looked like you did at least some basic analysis of this assertion failure in bug 1522243. Do you have time to look at why the failure rate rate is a lot higher in Fission, or maybe it is expected right now? Thanks.

Comment 15

[Chris Peterson [:cpeterson]]

Roll some unfixed bugs from Fission Milestone M4 to M5

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 16

[Chris Peterson [:cpeterson]]

M4.1 and WFM

kmag thinks this bug may have been fixed by enabling ServiceWorker e10s.