Closed Bug 1574654 Opened 5 years ago Closed 5 years ago

198,300 instances of "No active window" emitted from js/xpconnect/src/XPCJSContext.cpp during linux64 debug testing

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: erahm, Assigned: squib)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1574654 - Revert the order of operations in XPCJSContext::InterruptScript from bug 1493225; r?smaug
47 bytes, text/x-phabricator-request
Details | Review

198288 WARNING: No active window: file js/xpconnect/src/XPCJSContext.cpp, line 664

This warning [1] shows up in the following test suites:

  4149 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
  4043 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
  3045 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
  3037 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
  2969 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
  2966 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
  2737 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
  2729 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
  2706 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
  2702 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
  2643 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
  2640 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
  2616 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
  2611 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
  2560 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
  2549 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
  2394 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
  2307 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
  2303 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
  2233 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
  2233 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
  2226 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
  2224 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
  2216 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
  2196 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
  2090 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
  2084 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
  2042 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
  2041 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
  2036 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
  2026 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
  2012 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
  1962 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
  1961 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
  1859 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
  1855 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
  1738 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
  1735 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
  1723 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
  1678 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
  1643 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
  1632 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
  1616 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
  1606 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
  1605 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
  1589 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
  1586 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
  1574 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
  1563 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
  1531 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
  1527 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
  1527 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
  1493 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
  1485 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
  1480 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
  1379 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
  1366 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
  1292 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
  1234 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
  1227 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
  1143 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
  1142 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
  1101 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-5 bc5
  1098 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
  1096 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
  1096 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
  1076 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
  1074 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
  1074 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
  1071 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
  1059 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
  1055 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
   965 - test-linux64/debug-mochitest-sw-e10s-15 15
   962 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
   954 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
   948 - test-linux64/debug-mochitest-e10s-15 15
   931 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
   922 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
   920 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
   907 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-16 bc16
   881 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
   864 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-15 bc15
   850 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
   808 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
   804 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
   781 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
   736 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
   718 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
   706 - test-linux64/debug-mochitest-e10s-9 9
   704 - test-linux64/debug-mochitest-sw-e10s-9 9
   689 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
   686 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   683 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
   679 - test-linux64/debug-mochitest-fis-e10s-9 9
   657 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
   655 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
   643 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-8 bc8
   635 - test-linux64/debug-mochitest-fis-e10s-15 15
   633 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
   632 - test-linux64/debug-mochitest-media-fis-e10s-1 mda1
   611 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
   590 - test-linux64/debug-mochitest-fis-e10s-4 4
   590 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-12 dt12
   587 - test-linux64/debug-mochitest-e10s-2 2
   585 - test-linux64/debug-mochitest-fis-e10s-2 2
   577 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
   573 - test-linux64/debug-mochitest-sw-e10s-2 2
   563 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
   563 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
   556 - test-linux64/debug-mochitest-media-e10s-1 mda1
   549 - test-linux64/debug-mochitest-media-spi-e10s-1 mda1
   539 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-4 bc4
   538 - test-linux64/debug-mochitest-sw-e10s-4 4
   530 - test-linux64/debug-mochitest-e10s-4 4
   496 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
   496 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-11 bc11
   492 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
   485 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-1 bc1
   483 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
   482 - test-linux64/debug-mochitest-media-spi-e10s-2 mda2
   481 - test-linux64/debug-mochitest-media-e10s-2 mda2
   469 - test-linux64/debug-mochitest-media-fis-e10s-2 mda2
   463 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-10 bc10
   457 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
   450 - test-linux64/debug-mochitest-sw-e10s-8 8
   448 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
   444 - test-linux64/debug-mochitest-e10s-8 8
   433 - test-linux64/debug-mochitest-webgl1-ext-fis-e10s gl1e
   433 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-13 bc13
   432 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   428 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
   427 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-2 bc2
   420 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-3 bc3
   400 - test-linux64/debug-marionette-e10s Mn
   396 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-11 dt11
   390 - test-linux64/debug-mochitest-sw-e10s-12 12
   382 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-9 bc9
   376 - test-linux64/debug-mochitest-e10s-12 12
   358 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-12 bc12
   354 - test-linux64/debug-mochitest-fis-e10s-12 12
   329 - test-linux64/debug-mochitest-e10s-14 14
   328 - test-linux64/debug-mochitest-sw-e10s-13 13
   323 - test-linux64/debug-mochitest-sw-e10s-14 14
   320 - test-linux64/debug-mochitest-fis-e10s-13 13
   315 - test-linux64/debug-mochitest-fis-e10s-14 14
   308 - test-linux64/debug-mochitest-e10s-13 13
   300 - test-linux64/debug-mochitest-sw-e10s-11 11
   298 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-7 bc7
   292 - test-linux64/debug-mochitest-e10s-11 11
   291 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-14 bc14
   286 - test-linux64/debug-mochitest-fis-e10s-11 11
   283 - test-linux64/debug-mochitest-sw-e10s-7 7
   281 - test-linux64/debug-mochitest-e10s-7 7
   275 - test-linux64/debug-mochitest-fis-e10s-8 8
   258 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
   258 - test-linux64/debug-mochitest-webgl1-core-fis-e10s gl1c
   255 - test-linux64/debug-mochitest-browser-chrome-fis-e10s-6 bc6
   244 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
   240 - test-linux64/debug-mochitest-e10s-1 1
   240 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
   238 - test-linux64/debug-mochitest-e10s-5 5
   237 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
   237 - test-linux64/debug-mochitest-chrome-sw-1proc-2 c2
   236 - test-linux64/debug-mochitest-e10s-3 3
   235 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
   234 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
   234 - test-linux64/debug-mochitest-chrome-1proc-2 c2
   232 - test-linux64/debug-mochitest-sw-e10s-3 3
   231 - test-linux64/debug-mochitest-sw-e10s-1 1
   230 - test-linux64/debug-mochitest-sw-e10s-5 5
   230 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   229 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
   225 - test-linux64/debug-mochitest-chrome-sw-1proc-3 c3
   225 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
   218 - test-linux64/debug-mochitest-media-spi-e10s-3 mda3
   215 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
   213 - test-linux64/debug-mochitest-media-e10s-3 mda3
   211 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
   201 - test-linux64/debug-mochitest-chrome-1proc-3 c3
   197 - test-linux64/debug-mochitest-media-fis-e10s-3 mda3
   178 - test-linux64/debug-mochitest-fis-e10s-7 7
   164 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
   162 - test-linux64/debug-reftest-sw-e10s-7 R7
   160 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
   160 - test-linux64/debug-mochitest-fis-e10s-5 5
   160 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
   160 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
   160 - test-linux64/debug-reftest-sw-e10s-6 R6
   159 - test-linux64/debug-reftest-e10s-4 R4
   157 - test-linux64/debug-mochitest-chrome-sw-1proc-1 c1
   157 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
   157 - test-linux64/debug-mochitest-fis-e10s-3 3
   157 - test-linux64/debug-reftest-e10s-6 R6
   157 - test-linux64/debug-reftest-sw-e10s-3 R3
   157 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
   156 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
   156 - test-linux64/debug-reftest-e10s-3 R3
   155 - test-linux64/debug-reftest-e10s-7 R7
   155 - test-linux64/debug-reftest-sw-e10s-5 R5
   154 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
   153 - test-linux64/debug-reftest-sw-e10s-1 R1
   153 - test-linux64/debug-mochitest-chrome-1proc-1 c1
   153 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
   153 - test-linux64/debug-reftest-e10s-1 R1
   152 - test-linux64/debug-mochitest-e10s-6 6
   152 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
   152 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
   148 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
   148 - test-linux64/debug-mochitest-fis-e10s-6 6
   148 - test-linux64/debug-reftest-sw-e10s-4 R4
   147 - test-linux64/debug-reftest-e10s-5 R5
   146 - test-linux64/debug-mochitest-sw-e10s-6 6
   140 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
   139 - test-linux64/debug-reftest-sw-e10s-2 R2
   138 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
   136 - test-linux64/debug-mochitest-fis-e10s-1 1
   135 - test-linux64/debug-reftest-e10s-2 R2
   135 - test-linux64/debug-mochitest-e10s-10 10
   133 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
   129 - test-linux64/debug-mochitest-sw-e10s-10 10
   129 - test-linux64/debug-mochitest-fis-e10s-10 10
   128 - test-linux64/debug-mochitest-remote-e10s remote
   121 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-6 dt6
   119 - test-linux64/debug-mochitest-remote-sw-e10s remote
   116 - test-linux64/debug-mochitest-e10s-16 16
   114 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-10 dt10
   113 - test-linux64/debug-mochitest-sw-e10s-16 16
   108 - test-linux64/debug-mochitest-fis-e10s-16 16
    94 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-1 dt1
    89 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-2 dt2
    82 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-4 dt4
    75 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-3 dt3
    69 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-9 dt9
    63 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-5 dt5
    62 - test-linux64/debug-mochitest-gpu-e10s gpu
    60 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
    59 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-8 dt8
    54 - test-linux64/debug-mochitest-devtools-chrome-fis-e10s-7 dt7
    28 - test-linux64/debug-telemetry-tests-client-e10s c
    19 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
    12 - test-linux64/debug-reftest-e10s-8 R8
    12 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
    12 - test-linux64/debug-mochitest-a11y-sw-1proc a11y
    11 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
    11 - test-linux64/debug-reftest-sw-e10s-8 R8
    10 - test-linux64/debug-mochitest-a11y-1proc a11y
     9 - test-linux64/debug-crashtest-sw-e10s C
     9 - test-linux64/debug-crashtest-e10s C
     2 - test-linux64/debug-marionette-media-e10s MnM

It shows up in 28652 tests. A few of the most prevalent:

  8770 - [e10s] Shutdown
  1329 - [e10s] dom/tests/browser/browser_noopener.js
   834 -        Shutdown
   824 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingMessaging.js
   418 - [e10s] dom/base/test/test_timeout_clamp.html
   415 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingCookies.js
   415 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingSharedWorkers.js
   412 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingIndexedDbInWorkers.js
   406 - [e10s] toolkit/components/antitracking/test/browser/browser_blockingIndexedDb.js
   383 - [e10s] toolkit/components/antitracking/test/browser/browser_referrerDefaultPolicy.js

[1] https://hg.mozilla.org/mozilla-central/annotate/19cdc92b399fd0061f4a0af4adf0ec801a1395a1/js/xpconnect/src/XPCJSContext.cpp#l664

Bisection points to: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9242458b79d5ae6e9d48c9a2a591680d79c13211&tochange=9a0ce3016f03a914367e86c8339a8b885e309c83

Olli, Jim, does that sound possible?

Flags: needinfo?(jporter+bmo)
Flags: needinfo?(bugs)
Regressed by: 1493225

Eric, that does sound very likely. Thanks for the catch! Bug 1493225 reordered a few things in there and moved the warning before a couple of branches that could exit the interrupt early. I changed the implementation in bug 1549177 and moved things to a different function, but didn't 100% restore InterruptCallback to its prior state. I'll do that now. :)

Assignee: nobody → jporter+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(jporter+bmo)

This patch restores the order of the slow script checks in
XPJSContext::InterruptScript to avoid filling our logs with useless warnings
in debug builds.

Pushed by jporter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f42002cf8f1 Revert the order of operations in XPCJSContext::InterruptScript from bug 1493225; r=smaug

https://hg.mozilla.org/mozilla-central/rev/9f42002cf8f1

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

(Clearing the needinfo, since this was fixed)

Flags: needinfo?(bugs)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: