1574671 - Protections panel tries to work on chrome:// and about: URIs

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[(no longer active)]

For example go to chrome://global/skin/in-content/info-pages.css and open the protections panel. There's all sort of things there that don't make sense:

• Turning ETP on/off for the "site".
• "Protections for global" header.
• No trackers known to Nightly were detected on this page...

It's probably better to hide the panel toggle button similarly to how we hide it for about: pages for example...

Comment 1

[Johann Hofmann [:johannh]]

Hmm this is based on ContentBlockingAllowList.canHandle so we would probably have to fix where the contentBlockingAllowListPrincipal is exposed for that.

Comment 2

[Jorge]

Attachment: Bug 1574671 - Protections panel tries to work on chrome:// URIs - r=prathiksha

Depends on D66915

Comment 3

[Jorge]

Attachment: Bug 1574671 - Hide Protections panel on chrome:// and about: URIs r=johannh

Depends on D67744

Comment 4

[Jorge]

Attachment: Bug 1574671 - Protections panel tries to work on chrome:// URIs

Depends on D68242

Comment 5

[Johann Hofmann [:johannh]]

We'll cover content-privileged about: URIs like about:robots or about:compat in this bug, too.

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out changeset be1bf86b2d6c (Bug 1574671) for bc and TV failures in browser/base/content/test/protectionsUI/browser_protectionsUI_shield_visibility.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1819b9fe10ed1857b42bcca28eb133fdd9839c0d

bc: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=87b4d7ad037bcfe7aaccda9813f9991b1a3f3ba6&selectedJob=298896304
log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298896304&repo=autoland&lineNumber=7419

TV: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=87b4d7ad037bcfe7aaccda9813f9991b1a3f3ba6&selectedJob=298896814
log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298896814&repo=autoland&lineNumber=1432

Comment 7

[Jorge]

(In reply to Stefan Hindli [:stefan_hindli] from comment #6)

Backed out changeset be1bf86b2d6c (Bug 1574671) for bc and TV failures in browser/base/content/test/protectionsUI/browser_protectionsUI_shield_visibility.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1819b9fe10ed1857b42bcca28eb133fdd9839c0d

bc: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=87b4d7ad037bcfe7aaccda9813f9991b1a3f3ba6&selectedJob=298896304
log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298896304&repo=autoland&lineNumber=7419

TV: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=87b4d7ad037bcfe7aaccda9813f9991b1a3f3ba6&selectedJob=298896814
log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298896814&repo=autoland&lineNumber=1432

I've made the changes that resolves the errors.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2af1ee241c8
Hide Protections panel on chrome:// and about: URIs r=johannh

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f2af1ee241c8