1574732 - Top Sites on New Tab page are not labelled correctly (only lower case is used)

Status: RESOLVED DUPLICATE of bug 1868060

(Firefox :: New Tab Page, enhancement, P3)

Description

[Will]

Attachment: TopSites lower case.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

The labels for the Top Sites on the New Tab page are incorrect, they're all in lower case (YouTube is labelled "youtube", BBC is labelled "bbc" etc.). Please reconsider this

Expected results:

screenshots attached of Firefox vs Chrome

Comment 1

[Will]

Attachment: chome top sites correct.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Will]

Also, in some cases, spaces are removed too (see above, in Chrome "The Verge", in Firefox "theverge").

Comment 4

[Ed Lee :Mardak]

The label comes from the domain, e.g., youtube.com, bbc.co.uk, theverge.com

Comment 5

[Jessilyn Davis]

Thanks, Will!

Wolasi - what do you recommend?

Tawanda - P3 okay (in our backlog for TBD upcoming release)?

Comment 6

[Tawanda Kanhema]

Let's make this a P3 and schedule for upcoming release, 71 ok

Comment 7

[Wolasi :wolasi]

I think it should be Title case for proper names (e.g. Apple, Reddit, Gmail etc) and lowercase in the rare case we have to use urls (e.g. something.com)

Ok with shipping in 71

Comment 8

[Jessilyn Davis]

Synced with Tawanda - we're looking at doing some Top Sites polish work in Nightly 71. Pulling this in as a P1 to evaluate if we can get this fix into Nightly 71.

Comment 9

[Jayati Shrivastava]

Hi! Can I work on this?

Comment 10

[Will]

Attachment: enwikifftopsite.png

another example of why this needs to be changed: my Wikipedia top site is labelled "en.wikipedia"
(the URL for it is https://en.wikipedia.org/wiki/Main_Page ).

Comment 11

[Will]

Sorry to come back to this again but my friend just observed that the top sites in Fenix (new Firefox for Android) don't have this problem. Firefox for Desktop should probably just do whatever Fenix is doing with top site labels.

Comment 12

[Will]

Attachment: iLzYHZ2.png

I just noticed in some Proton mocks that this is fixed, but I can't find a bug for it and it's not fixed in Nightly. Anyone have more info about this?

Comment 13

[Will]

Gentle ping. This is worth fixing now, it's a highly visible issue...

Comment 14

[Jai Sai Chand Tumu]

If this issue is available I'd take it, if anyone sees this could you please assign me.. Thanks

Comment 15

[Vincent Hilla [:vhilla]]

A first step might be to add link.title here, though that does not seem to work for top sites from bookmarks.

Comment 16

[:Gijs (away/busy until Mar 10)]

Fixed in bug 1868060, AIUI.