1574849 - [mozdevice] add GV and Fenix specific code

Status: RESOLVED WONTFIX

(Testing :: Mozbase, enhancement, P3)

Description

[Tarek Ziadé (:tarek)]

We have "launch_fennec" at https://searchfox.org/mozilla-central/source/testing/mozbase/mozdevice/mozdevice/adb.py#3185

I'd like to introduce "launch_geckoview", mainly to push the specific yml file we need to run GV or Fenix, along with the set-debug flag

e.g. https://mozilla.github.io/geckoview/consumer/docs/automation#reading-configuration-from-a-file

Comment 1

[Bob Clary [:bc] (inactive)]

Seems reasonable. We should take care to handle the other uses in the tree so that we are consistent with the current launching of geckoview apps.

https://searchfox.org/mozilla-central/source/mobile/android/mach_commands.py#454
https://searchfox.org/mozilla-central/source/testing/raptor/raptor/raptor.py#881

gbrown, rwood: What do you think?

Comment 2

[Geoff Brown [:gbrown]]

There's also harness code like https://searchfox.org/mozilla-central/rev/5912f376ab6a17afcba2b7654586013158ed64b5/build/mobile/remoteautomation.py#229.

So far we have been using launch_application or launch_activity for geckoview_example and TestRunnerActivity. I suppose we could have harness code push(local_yml_path, remote_yml_path) + launch_activity(), but if the yml file is useful for geckoview apps in general or there are other geckoview-specific features involved in the launch, launch_geckoview() seems like the right way forward.

Comment 3

[Robert Wood [:rwood]]

(In reply to Bob Clary [:bc:] from comment #1)

Seems reasonable. We should take care to handle the other uses in the tree so that we are consistent with the current launching of geckoview apps.

https://searchfox.org/mozilla-central/source/mobile/android/mach_commands.py#454
https://searchfox.org/mozilla-central/source/testing/raptor/raptor/raptor.py#881

gbrown, rwood: What do you think?

Sounds good to me!

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 5

[Geoff Brown [:gbrown]]

I think launch_application and launch_activity are sufficient.