1574883 - The Mobile Promotion from “about:logins” page overlaps with the "Login Item" when resizing the browser

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: Mobilepromotion_overlaps.mp4

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-18) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• The Firefox browser is opened.
• You are signed with a valid FxA.

[Steps to reproduce]:

1. Navigate to “about:logins” page.
2. Resize the browser to it's half.
3. Observe the behavior.

[Expected result]:

• The content of the banner is responsive and correctly displayed.

[Actual result]:

• The Mobile Promotion overlaps the elements from the page.

[Notes]:

• The Mobile Promotion overlaps the elements from the “Login Item” and “Edit” mode on the smaller screens. (e.g., macbook)
• Attached a screen recording with the issue.

Comment 1

[Matthew N. [:MattN]]

This would be fixed by moving the promo to be a child of <login-item>. This is somewhat expected behaviour though so marking as P3.

Comment 2

[David Durst [:ddurst]]

Ryan, I assumed this would be placed in the login item pane, rather than being fixed at the bottom of the screen (because my assumption is that the content takes up a small enough vertical space that there should be room for it most of the time, and only encroaching when the user has reduced the height of the window (or introducing the dev tools pane, etc)).

But. That was my guess. Your call on whether this should be fixed position (as it is now) or placed at the bottom of that content area and not able to drift up as the attached video shows.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-27)(64-bit) build on Windows 7 x64, Mac 10.14 and Arch Linux 4.12.

• The Mobile Promotion remains at the bottom of the page and doesn't overlap with the "Login Item" when vertically resizing the browser.