1574915 - Fix some ESLint issues raised by ESLint 6

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

Splitting landing these out from bug 1551829, since we need to wait a little (for another eslint release) before we can push that, but it is worth getting reviews going on these bits.

Two things here:

• Fix issues raised by no-useless-catch
• Fix a few instances where we're using async functions as promise executors.

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dda1c521386b93bc0fdbdc4423c71c0fd5401997

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1574915 - Fix some instances of using async functions as promise executors. r?Mossop

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1574915 - Fix useless try-catch issues in dom/. r?hsivonen

Depends on D42508

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1574915 - Fix useless try-catch issues in toolkit/. r?Mossop

Depends on D42509

Comment 5

[Mark Banner (:standard8)]

Updated try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e88a03973338d437c69a63f5e5a2b8202f59a56a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb5e96215364
Fix some instances of using async functions as promise executors. r=mossop
https://hg.mozilla.org/integration/autoland/rev/31411ef8fef5
Fix useless try-catch issues in dom/. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/981508114728
Fix useless try-catch issues in toolkit/. r=mossop

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/eb5e96215364
https://hg.mozilla.org/mozilla-central/rev/31411ef8fef5
https://hg.mozilla.org/mozilla-central/rev/981508114728