1574991 - Remove "In Browser Element" from about:cache

Status: RESOLVED FIXED

(Core :: Networking: Cache, task, P3)

Description

[(no longer active)]

The underlying origin attribute is being removed in bug 1566186.

Comment 1

[Mahak]

hey @ehsan
Can I take this up and could you please elaborate this more ?
Thanks :)

Comment 2

[Andrea Marchesini [:baku]]

I can answer here.

In about:cache we show an "in browser element" checkbox. But we removed 'browser elements' in bug 1566186. This means that that checkbox is useless. This bug is about removing that checkbox and the code related to it.

If you want to work on this bug, I'm happy to review your patch/patches.
Thanks.

Comment 3

[Mahak]

Hey {:baku]
Thanks for the information . I would love to work on this :)
Could you please help me locate the file which needs modification ?
Thanks:)

Comment 4

[Andrea Marchesini [:baku]]

https://searchfox.org/mozilla-central/rev/2cd2d511c0d94a34fb7fa3b746f54170ee759e35/netwerk/protocol/about/nsAboutCache.cpp

Comment 5

[Mahak]

Hey [:baku]
I think this is the only place where "in browser element" checkbox is used .
https://searchfox.org/mozilla-central/rev/2cd2d511c0d94a34fb7fa3b746f54170ee759e35/netwerk/protocol/about/nsAboutCache.cpp#102-107
Am I proceeding right ?
Thanks :)

Comment 6

[Andrea Marchesini [:baku]]

You need to change https://searchfox.org/mozilla-central/rev/2cd2d511c0d94a34fb7fa3b746f54170ee759e35/toolkit/components/aboutcache/content/aboutCache.js too.

Comment 7

[Mahak]

Attachment: Bug 1574991 - Remove "In Browser Element" from about:cache.r?baku

Comment 8

[Andrea Marchesini [:baku]]

Mahak, do you want me to land the patch for you?

Comment 9

[Mahak]

Yeah It would be great if you could do so .
Thanks :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c91231bf4b3
Remove "In Browser Element" from about:cache.r=baku

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5c91231bf4b3