1575071 - Step Over with blackboxing fails

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jason Laster [:jlast]]

STR:

1. go to https://firefox-dev.tools/debugger-examples/examples/todomvc/
2. blackbox log.js
3. edit a todo
4. click on the message "start editing" (land on line 77)
5. press step over

ER: go to 78
AR: resumes

Note, this works w/o web replay

Here is a long video of me futzing with it https://www.loom.com/share/66db34cfc0ba4c49b0e1c8ed68443415

Comment 1

[Brian Hackett [Laid off!]]

I think the problem here is not specific to web replay: when the server has paused at a location within a blackboxed source, it has trouble stepping forward whether web replay is turned on or not. I can't reproduce this specific STR without web replay because message warping is only supported with web replay on, but here are similar STR without web replay:

1. go to https://firefox-dev.tools/debugger-examples/examples/todomvc/
2. set a breakpoint at the start of logTodo in log.js
3. edit a todo, so that the debugger pauses at the breakpoint
4. blackbox log.js
5. press step over

The process then resumes, when it seems better that it should step out to the first non-blackboxed frame. Fixing this in the non-web-replay case will probably fix the web replay case as well.

Comment 2

[mattheww]

I'm interested in working on this if it's available, please.

Comment 3

[mattheww]

Attachment: Bug 1575071 - Add onPop handlers to blackboxed frames

Comment 4

[mattheww]

Attachment: Bug 1575071 - Improve performance by not attaching onStep handlers to blackboxed frames

Depends on D57203

Comment 5

[mattheww]

Attachment: Bug 1575071 - Find unblackboxed frame when stepping backwards

Depends on D57205

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e954fcf48719
Add onPop handlers to blackboxed frames r=jlast

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2670c21ed98
Improve performance by not attaching onStep handlers to blackboxed frames r=jlast
https://hg.mozilla.org/integration/autoland/rev/a2d268317ed1
Find unblackboxed frame when stepping backwards r=jlast

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e954fcf48719
https://hg.mozilla.org/mozilla-central/rev/b2670c21ed98
https://hg.mozilla.org/mozilla-central/rev/a2d268317ed1