Closed
Bug 1575096
Opened 6 years ago
Closed 6 years ago
Disable beforeunload/unload event breakpoints until they work on the main window
Categories
(DevTools :: Debugger, task, P1)
DevTools
Debugger
Tracking
(firefox69 fixed, firefox70 fixed)
RESOLVED
FIXED
Firefox 70
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-reserve])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Since https://bugzilla.mozilla.org/show_bug.cgi?id=1569775 is an issue, we should remove these events from the available event breakpoint list for now.
Assignee | ||
Updated•6 years ago
|
Blocks: dbg-event-bps, dbg-70
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Attachment #9086546 -
Attachment description: Bug 1569775 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast → Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
Updated•6 years ago
|
Whiteboard: [debugger-reserve]
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0b2d7e9e932
Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
Comment 3•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 9086546 [details]
Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
Beta/Release Uplift Approval Request
- User impact if declined:
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is essentially removing 2 checkboxes from the debugger UI and should have no other effect.
- String changes made/needed:
Attachment #9086546 -
Flags: approval-mozilla-beta?
Comment 5•6 years ago
|
||
Comment on attachment 9086546 [details]
Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
Disables buggy functionality that isn't ready to ship yet. Approved for 69.0b16.
Attachment #9086546 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•6 years ago
|
||
bugherder uplift |
status-firefox69:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•