1575136 - Distinguish pop-up windows with X11 property

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Thayne]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Open a popup window (for example: https://codepen.io/tmccombs/pen/bGbwLMe, or something that opens a pop-up authentication flow, such as with google oauth) in linux with X11
2. Examine properties with xprop

Actual results:

There is nothing to distinguish a pop-up window from a regular window. For my use case, this means it is impossible for me to target pop-up windows with an i3 rule. In particular I would like to configure i3 to make pop-up windows floating, but afaict there is no way to do this with firefox. Instead, the pop-up fills my full screen, which is often a poor experience.

Expected results:

There should be some indication to the window manager that this is a pop-up. For example, chrome sets the WM_WINDOW_ROLE property to "pop-up". Using a special value for the instance or class (WM_CLASS property) or setting the _NET_WM_WINDOW_TYPE to _NET_WM_WINDOW_TYPE_DIALOG would also work for my usecase at least.

Comment 1

[Gyula Palko[:gpalko]]

Hi,
I'm setting the component in order to involve the development team in reviewing this.
Thanks!

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Dupe of Bug 397251, let's solve it there.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Does not look like dupe of Bug 397251 after all, better to resolve it here. Do I understand correctly that you want to set WM_WINDOW_ROLE "pop-up" for all popup window?

Comment 4

[Thayne]

Do I understand correctly that you want to set WM_WINDOW_ROLE "pop-up" for all popup window?

Yes

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1575136 - [Linux/Gtk] Set initial wm_role for windows, r=jhorak

Comment 6

[Martin Stránský [:stransky] (ni? me)]

I think I understand you. But what you need is to set various role to toplevel window as the window from you example is toplevel type but acts as pop-up. The patch attached here does not fix your issue but gives all windows some initial wm_role.

Actual wm_role for each window needs to be set per-window, as it's for PIP window for instance, see:

https://hg.mozilla.org/integration/autoland/file/969b3828a301038c57540d8bffb51539132d393c/toolkit/components/pictureinpicture/PictureInPicture.jsm

the PIP window is created as toplevel/dialog but it uses:

WINDOW_TYPE = "Toolkit:PictureInPicture";

to set different WM_CLASS/WM_ROLE to it.

So what you need is to identify particular windows you're interested in and file bug against Firefox product for it. Feel free to CC me there and I can help to find particular component/reviewer.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4231201173d
[Linux/Gtk] Set initial wm_role for windows, r=jhorak

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b4231201173d