1575144 - update Geolocation implementation to match latest spec

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P2)

Description

[Anssi Kostiainen]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Steps to reproduce:

The Geolocation API specification renamed the following interfaces and removed the [NoInterfaceObject] annotation so that these types are now exposed to script:

Coordinates -> GeolocationCoordinates
Position -> GeolocationPosition
PositionError -> GeolocationPositionError

This is done in response to an effort to remove the [NoInterfaceObject] annotation from WebIDL.

Spec pull requests (merged):
https://github.com/w3c/geolocation-api/pull/20
https://github.com/w3c/geolocation-api/pull/23

Comment 1

[Marcos Caceres [:marcosc]]

Also https://github.com/w3c/geolocation-api/pull/32

Comment 2

[Andrei Purice]

Hello,
I have set the component for this issue, but since i'm not sure if this is the right component please feel free to change it to one that suits it.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 4

[:garvan]

Marcos: are you able to assign this bug to yourself?

Comment 5

[Marcos Caceres [:marcosc]]

Yep, I'll grab it... saving this for an intern who might be starting soon.

Comment 6

[Marcos Caceres [:marcosc]]

Sid kindly offered to help us with it.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74b6ab31dd2ed91104160d313be87f830ab29d7b

Comment 7

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Part 1: Remove [NoInterfaceObject] from Geolocation

Comment 8

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Part 2: Rename Coordinates to GeolocationCoordinates

Depends on D51791

Comment 9

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Part 3: Rename Position to GeolocationPosition

Depends on D51792

Comment 10

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Part 4: Rename PositionError to GeolocationPositionError

Depends on D51793

Comment 11

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Part 5: Update WPT for geolocation-API

Depends on D51794

Comment 12

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Update interface tests, SecureContext on GeolocationPosition, GeolocationCoordinates

Depends on D51795

Comment 13

[Marcos Caceres [:marcosc]]

Including https://github.com/w3c/geolocation-api/pull/34

Comment 14

[Sid Vishnoi :sidvishnoi]

Attachment: Bug 1575144 - Update Geolocation implementation to match latest spec

The Geolocation API specification renamed the following interfaces and removed the [NoInterfaceObject] annotation so that these types are now exposed to script:

• Coordinates -> GeolocationCoordinates
• Position -> GeolocationPosition
• PositionError -> GeolocationPositionError

This is done in response to an effort to remove the [NoInterfaceObject]
annotation from WebIDL.

Additionally, the following interfaces are now only exposed in Secure Contexts:

• GeolocationCoordinates
• GeolocationPosition

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aab5f870bf5e
Update Geolocation implementation to match latest spec r=baku,marcosc

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/aab5f870bf5e

Comment 17

[Chris Mills [:cmills]]

I've had a go at documenting this one on MDN; see https://github.com/mdn/sprints/issues/2461#issuecomment-564114752 for the full details.

Please let me know if I've missed anything; thanks!

Comment 18

[Sid Vishnoi :sidvishnoi]

Amazing work Chris! I didn't realize this many documents needed to be changed! Thank you for your work.