1575155 - Lockwise UI - Breach exclamation marks shown on all logins due to nsIURI.host throwing

Status: RESOLVED FIXED

(Firefox :: about:logins, defect, P1)

Description

[vtol]

Attachment: lockwise screenshot

• W10 Pro x_64 1908 b18362.295
• FX 70.0a1 (2019-08-19) (64-bit)

---

Since a few build Lockwise UI is exhibiting those exclamation marks and the buttons edit | delete | launch | copy | password reveal are unresponsive.

Comment 1

[vtol]

Attachment: error console output screenshot

opening about:logins produces those errors in the browser console.

Comment 2

[vtol]

Attachment: banner blocking button inertaction

The Lockwise app banner is causing the buttons being unresponsive - the screencast done on a maiden browser profile.

Comment 3

[Matthew N. [:MattN]]

Are the exclamation marks shown on all logins or just ones that were in a breach?

(In reply to vtol from comment #0)

and the buttons edit | delete | launch | copy | password reveal are unresponsive.

This part is bug 1574869. Let's focus this bug on the exclamation marks.

The error with nsIURI.host may be relevant.

Thanks

Comment 4

[vtol]

Showing on all stored logins, in this profile that being 214 entries and some are non-public ip ranges, respectively not publicly resolvable domains.

N.B. The meaning of the exclamation mark is not apparent to me, there is nothing when hovering over it with the cursor or clicking on it - that was until you mentioned this being related to breached accounts in f.mon

Comment 5

[Lesley Norton [:lnorton]]

Working on reproducing this presently - it's interesting that the favicons aren't showing up either.

Comment 6

[Lesley Norton [:lnorton]]

Hi :vtol, you mention in comment #2 that this is a screencast and I'm wondering - are these warning icons persistent or do they flash on page load/reload?

Comment 7

[vtol]

obsolted the screencast in this bug as been rather pertinent to bug 1574869 where it resides now in comment #1.

since I have no way of obfuscating the screencast I canot post one here when pressing F5. The icons are persisent/stable once the dom redraw process finishes, no flashing/blinking/flickering of sorts.

Comment 8

[Matthew N. [:MattN]]

(In reply to Lesley Norton [:lnorton] from comment #5)

Working on reproducing this presently - it's interesting that the favicons aren't showing up either.

There is one concrete lead in this bug which is the error message with line number. Did you look at what that line was doing? The error is probably preventing the favicon code from running so that's also a hint that the error is before the favicon message.

Comment 9

[Lesley Norton [:lnorton]]

Attachment: Bug 1575155: Handle exceptions thrown by non-standard URIs. r=mattn

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d779671a20bf
Handle exceptions thrown by non-standard URIs. r=MattN

Comment 11

[vtol]

Attachment: screenshot browser console of recent browser launch and opening the login

Not sure that nsIURI.host is the cause really. The FX instance meantime been advanced to build 835d0d9cdae81b3ab583d4ccf7459d00b041fad6 and whilst the nsIURI.host error does not show in the browser console the exclamation marks are still present and the favicons are not showing.

The browser console does not provide anything meaningful related to the issue - see screenshot of browser console since having launched the browser and opened about:login

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d779671a20bf

Comment 13

[Matthew N. [:MattN]]

(In reply to vtol from comment #11)

Created attachment 9087284 [details]
screenshot browser console of recent browser launch and opening the login

Not sure that nsIURI.host is the cause really. The FX instance meantime been advanced to build 835d0d9cdae81b3ab583d4ccf7459d00b041fad6 and whilst the nsIURI.host error does not show in the browser console the exclamation marks are still present and the favicons are not showing.

The browser console does not provide anything meaningful related to the issue - see screenshot of browser console since having launched the browser and opened about:login

Let us know if the issue is solved in the latest Nightly. If not, please file a new bug and include the Browser Console logs after flipping signon.debug to true in about:config.

Thanks

Comment 14

[vtol]

works for me, thank you