1575161 - Remove CodeLocationJump, CodeOffsetJump, CodeLocationLabel::repoint

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Jan de Mooij [:jandem]]

There's some really complicated code here that we can just remove if we stop using it in the IonIC code.

Comment 1

[Jan de Mooij [:jandem]]

Also RepatchLabel, labelForPatch I think.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1575161 part 1 - Stop using CodeOffsetJump, RepatchLabel, PatchJump etc in the IonIC code. r?tcampbell!

This will let us remove a lot of dead code in the next patch.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1575161 part 2 - Remove now unused CodeOffsetJump, RepatchLabel, PatchJump and related code. r?tcampbell!

Removes about 850 lines of pretty complicated code.

Depends on D42621

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1575161 part 3 - Simplify CodeLocationLabel now that it's only used with absolute addresses. r?tcampbell!

Depends on D42622

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1575161 part 4 - Delete now empty Assembler-shared.cpp file. r?tcampbell!

Depends on D42623

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50cea5fa0187
part 1 - Stop using CodeOffsetJump, RepatchLabel, PatchJump etc in the IonIC code. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d924c53aa1ee
part 2 - Remove now unused CodeOffsetJump, RepatchLabel, PatchJump and related code. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/402e7c3f87e7
part 3 - Simplify CodeLocationLabel now that it's only used with absolute addresses. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f4fe0cc774b7
part 4 - Delete now empty Assembler-shared.cpp file. r=tcampbell

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/50cea5fa0187
https://hg.mozilla.org/mozilla-central/rev/d924c53aa1ee
https://hg.mozilla.org/mozilla-central/rev/402e7c3f87e7
https://hg.mozilla.org/mozilla-central/rev/f4fe0cc774b7